Make ObservingAutofillClient a WebContentsUserData

Make ObservingAutofillClient a WebContentsUserData

ObservingAutofillClient was triggering a stack-use-after-return under certain
circumstances (see bug), presumably because the WebContents and
ContentPasswordManagerDriver stayed alive after the local
ObservingAutofillClient variable was deleted when the test body returned.

This change makes ObservingAutofillClient a WebContentsUserData so that it
matches the lifetime of the WebContents which outlives the
ContentPasswordManagerDriver that uses it. This matches how the production code
works as well (ChromeAutofillClient is a WebContentsUserData).

BUG=681710
Review-Url: https://codereview.chromium.org/2641653002
Cr-Commit-Position: refs/heads/master@{#444380}
Committed: https://chromium.googlesource.com/chromium/src/+/921882bd5ee50f1e59288a51f0fd018261f3ffc2

[estark, 2017-01-17 23:59:08]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 23:59:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-01-18 00:00:04]

estark@chromium.org changed reviewers:
+ vasilii@chromium.org

[estark, 2017-01-18 00:00:05]

vasilii, PTAL? Thanks!

[commit-bot: I haz the power, 2017-01-18 00:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:45:09]

Dry run: This issue passed the CQ dry run.

[vasilii, 2017-01-18 12:10:03]

lgtm

I'm a bit concerned that ChromeAutofillClient is also instantiated for the same
tab via TabHelpers::AttachTabHelpers. But this was the case before the CL too.

[estark, 2017-01-18 16:09:28]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-01-18 16:09:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 16:13:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484755768515660, "parent_rev":
"efcb118837841dd91bd77838b70a2be7dded1f13", "commit_rev":
"921882bd5ee50f1e59288a51f0fd018261f3ffc2"}

[commit-bot: I haz the power, 2017-01-18 16:14:24]

Description was changed from

==========
Make ObservingAutofillClient a WebContentsUserData

ObservingAutofillClient was triggering a stack-use-after-return under certain
circumstances (see bug), presumably because the WebContents and
ContentPasswordManagerDriver stayed alive after the local
ObservingAutofillClient variable was deleted when the test body returned.

This change makes ObservingAutofillClient a WebContentsUserData so that it
matches the lifetime of the WebContents which outlives the
ContentPasswordManagerDriver that uses it. This matches how the production code
works as well (ChromeAutofillClient is a WebContentsUserData).

BUG=681710
==========

to

==========
Make ObservingAutofillClient a WebContentsUserData

ObservingAutofillClient was triggering a stack-use-after-return under certain
circumstances (see bug), presumably because the WebContents and
ContentPasswordManagerDriver stayed alive after the local
ObservingAutofillClient variable was deleted when the test body returned.

This change makes ObservingAutofillClient a WebContentsUserData so that it
matches the lifetime of the WebContents which outlives the
ContentPasswordManagerDriver that uses it. This matches how the production code
works as well (ChromeAutofillClient is a WebContentsUserData).

BUG=681710

Review-Url: https://codereview.chromium.org/2641653002
Cr-Commit-Position: refs/heads/master@{#444380}
Committed:
https://chromium.googlesource.com/chromium/src/+/921882bd5ee50f1e59288a51f0fd...
==========

[commit-bot: I haz the power, 2017-01-18 16:14:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/921882bd5ee50f1e59288a51f0fd...