Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2641573003: Add DCHECK(rootBox) to InlineFlowBox::computeLogicalBoxHeights (Closed)

Created:
3 years, 11 months ago by eae
Modified:
3 years, 11 months ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK(rootBox) to InlineFlowBox::computeLogicalBoxHeights BUG=664851 TBR=szager@chromium.org Review-Url: https://codereview.chromium.org/2641573003 Cr-Commit-Position: refs/heads/master@{#444245} Committed: https://chromium.googlesource.com/chromium/src/+/b59fc7500d6007bea7ec137c2d9239d30922e2c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641573003/1
3 years, 11 months ago (2017-01-17 23:46:14 UTC) #2
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 02:18:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b59fc7500d6007bea7ec137c2d92...

Powered by Google App Engine
This is Rietveld 408576698