add COMPONENT/TEAM to OWNERS

Please help us to verify the TEAM/COMPONENT information. If the current information is incorrect, please suggest the correct team or component or None(if not applicable). 

BUG=679905
R=tyoshino

Review-Url: https://codereview.chromium.org/2641543002
Cr-Commit-Position: refs/heads/master@{#444585}
Committed: https://chromium.googlesource.com/chromium/src/+/c11dd43622d564f950c0d1f3e940507e32e25a87

[ymzhang1, 2017-01-17 19:51:27]

Description was changed from

==========
add COMPONENT/TEAM to OWNERS

BUG=679905
R=tyoshino
==========

to

==========
Please help us to verify the TEAM/COMPONENT information. If the current
information is incorrect, please suggest the correct team or component or
None(if not applicable). 

BUG=679905
R=tyoshino
==========

[ymzhang1, 2017-01-17 19:52:38]

Hello, 

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS file? Thank you very much!

[tyoshino (SeeGerritForStatus), 2017-01-18 10:26:31]

tyoshino@chromium.org changed reviewers:
+ eae@chromium.org, kouhei@chromium.org, toyoshim@chromium.org

[tyoshino (SeeGerritForStatus), 2017-01-18 10:26:32]

We had a @google.com list in the spreadsheet. Do we need to make it open to non
@google.com domain?

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS
File content/renderer/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS#new...
content/renderer/OWNERS:21: # COMPONENT: Internals>Core
This directly contains code of various teams. So, adding only
layout-dev@chromium.org shouldn't make much sense, I think.

Adding eae@ to see if having layout-dev@ is ok. But still need to list all the
TEAMs who have code they own here.

https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS
File net/data/websocket/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
net/data/websocket/OWNERS:4: 
It's ok to add
TEAM: blink-network-stack@google.com

https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
net/data/websocket/OWNERS:5: # COMPONENT: Internals>Network
For now, please use Blink>Network>WebSockets.

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/OWNERS:7: # COMPONENT: Blink>Loader
lg

Adding toyoshim@ who's making big refactoring on this directory.

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/xmlhttprequest/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/xmlhttprequest/OWNERS:7: # COMPONENT:
Blink>Network
Please use Blink>Network>XHR

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/eventsource/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/eventsource/OWNERS:5: # COMPONENT:
Blink>Network>FetchAPI
Please use Blink>Network

[tyoshino (SeeGerritForStatus), 2017-01-18 10:27:21]

toyoshim@: I added you just FYI as it includes core/fetch. No need to review.

[eae, 2017-01-18 16:53:55]

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS
File content/renderer/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS#new...
content/renderer/OWNERS:21: # COMPONENT: Internals>Core
On 2017/01/18 10:26:32, tyoshino wrote:
> This directly contains code of various teams. So, adding only
> mailto:layout-dev@chromium.org shouldn't make much sense, I think.
> 
> Adding eae@ to see if having layout-dev@ is ok. But still need to list all the
> TEAMs who have code they own here.

No, layout-dev only owns a small fraction of the code in this direcotry.

[ymzhang1, 2017-01-18 18:18:51]

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS
File content/renderer/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS#new...
content/renderer/OWNERS:21: # COMPONENT: Internals>Core
On 2017/01/18 16:53:55, eae wrote:
> On 2017/01/18 10:26:32, tyoshino wrote:
> > This directly contains code of various teams. So, adding only
> > mailto:layout-dev@chromium.org shouldn't make much sense, I think.
> > 
> > Adding eae@ to see if having layout-dev@ is ok. But still need to list all
the
> > TEAMs who have code they own here.
> 
> No, layout-dev only owns a small fraction of the code in this direcotry.

We will only have one component and one team for each directory or none (if
there's no major component). Would it be better if I remove TEAM and COMPONENT
information here?

[Charlie Harrison, 2017-01-18 18:21:24]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-01-18 18:21:24]

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS
File content/renderer/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS#new...
content/renderer/OWNERS:21: # COMPONENT: Internals>Core
On 2017/01/18 18:18:50, ymzhang1 wrote:
> On 2017/01/18 16:53:55, eae wrote:
> > On 2017/01/18 10:26:32, tyoshino wrote:
> > > This directly contains code of various teams. So, adding only
> > > mailto:layout-dev@chromium.org shouldn't make much sense, I think.
> > > 
> > > Adding eae@ to see if having layout-dev@ is ok. But still need to list all
> the
> > > TEAMs who have code they own here.
> > 
> > No, layout-dev only owns a small fraction of the code in this direcotry.
> 
> We will only have one component and one team for each directory or none (if
> there's no major component). Would it be better if I remove TEAM and COMPONENT
> information here?

Yes, please remove the TEAM/COMPONENT, this directory shares code between many
teams working inside and outside Blink.

[ymzhang1, 2017-01-18 19:11:35]

ymzhang@chromium.org changed reviewers:
+ sshruthi@chromium.org

[ymzhang1, 2017-01-18 19:11:36]

Regarding @google.com list, we could add it for now and change to @chromium.org
list in the future. 

Or if it's better to not make it open to non @google.com, we could remove team
information in OWNERS files.

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS
File content/renderer/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS#new...
content/renderer/OWNERS:21: # COMPONENT: Internals>Core
On 2017/01/18 18:21:24, Charlie Harrison wrote:
> On 2017/01/18 18:18:50, ymzhang1 wrote:
> > On 2017/01/18 16:53:55, eae wrote:
> > > On 2017/01/18 10:26:32, tyoshino wrote:
> > > > This directly contains code of various teams. So, adding only
> > > > mailto:layout-dev@chromium.org shouldn't make much sense, I think.
> > > > 
> > > > Adding eae@ to see if having layout-dev@ is ok. But still need to list
all
> > the
> > > > TEAMs who have code they own here.
> > > 
> > > No, layout-dev only owns a small fraction of the code in this direcotry.
> > 
> > We will only have one component and one team for each directory or none (if
> > there's no major component). Would it be better if I remove TEAM and
COMPONENT
> > information here?
> 
> Yes, please remove the TEAM/COMPONENT, this directory shares code between many
> teams working inside and outside Blink.

Done.

https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS
File net/data/websocket/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
net/data/websocket/OWNERS:4: 
On 2017/01/18 10:26:32, tyoshino wrote:
> It's ok to add
> TEAM: mailto:blink-network-stack@google.com

Done.

https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
net/data/websocket/OWNERS:5: # COMPONENT: Internals>Network
On 2017/01/18 10:26:32, tyoshino wrote:
> For now, please use Blink>Network>WebSockets.

Done.

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/xmlhttprequest/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/xmlhttprequest/OWNERS:7: # COMPONENT:
Blink>Network
On 2017/01/18 10:26:32, tyoshino wrote:
> Please use Blink>Network>XHR

Done.

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/eventsource/OWNERS (right):

https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/eventsource/OWNERS:5: # COMPONENT:
Blink>Network>FetchAPI
On 2017/01/18 10:26:32, tyoshino wrote:
> Please use Blink>Network

Done.

[chromium-reviews, 2017-01-18 20:54:03]

@google.com mailing list is fine for now, with plans to move to @
chromium.org in the future.

On Wed, Jan 18, 2017 at 11:11 AM <ymzhang@chromium.org> wrote:

> Regarding @google.com list, we could add it for now and change to @
> chromium.org
> list in the future.
>
> Or if it's better to not make it open to non @google.com, we could remove
> team
> information in OWNERS files.
>
>
>
>
>
>
> https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS
> File content/renderer/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS#new...
> content/renderer/OWNERS:21: # COMPONENT: Internals>Core
> On 2017/01/18 18:21:24, Charlie Harrison wrote:
> > On 2017/01/18 18:18:50, ymzhang1 wrote:
> > > On 2017/01/18 16:53:55, eae wrote:
> > > > On 2017/01/18 10:26:32, tyoshino wrote:
> > > > > This directly contains code of various teams. So, adding only
> > > > > mailto:layout-dev@chromium.org shouldn't make much sense, I
> think.
> > > > >
> > > > > Adding eae@ to see if having layout-dev@ is ok. But still need
> to list all
> > > the
> > > > > TEAMs who have code they own here.
> > > >
> > > > No, layout-dev only owns a small fraction of the code in this
> direcotry.
> > >
> > > We will only have one component and one team for each directory or
> none (if
> > > there's no major component). Would it be better if I remove TEAM and
> COMPONENT
> > > information here?
> >
> > Yes, please remove the TEAM/COMPONENT, this directory shares code
> between many
> > teams working inside and outside Blink.
>
> Done.
>
> https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS
> File net/data/websocket/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
> net/data/websocket/OWNERS:4:
> On 2017/01/18 10:26:32, tyoshino wrote:
> > It's ok to add
> > TEAM: mailto:blink-network-stack@google.com
>
> Done.
>
>
>
https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
> net/data/websocket/OWNERS:5: # COMPONENT: Internals>Network
> On 2017/01/18 10:26:32, tyoshino wrote:
> > For now, please use Blink>Network>WebSockets.
>
> Done.
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/xmlhttprequest/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/xmlhttprequest/OWNERS:7: # COMPONENT:
> Blink>Network
> On 2017/01/18 10:26:32, tyoshino wrote:
> > Please use Blink>Network>XHR
>
> Done.
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/eventsource/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/eventsource/OWNERS:5: # COMPONENT:
> Blink>Network>FetchAPI
> On 2017/01/18 10:26:32, tyoshino wrote:
> > Please use Blink>Network
>
> Done.
>
> https://codereview.chromium.org/2641543002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2017-01-18 20:54:03]

@google.com mailing list is fine for now, with plans to move to @
chromium.org in the future.

On Wed, Jan 18, 2017 at 11:11 AM <ymzhang@chromium.org> wrote:

> Regarding @google.com list, we could add it for now and change to @
> chromium.org
> list in the future.
>
> Or if it's better to not make it open to non @google.com, we could remove
> team
> information in OWNERS files.
>
>
>
>
>
>
> https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS
> File content/renderer/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/content/renderer/OWNERS#new...
> content/renderer/OWNERS:21: # COMPONENT: Internals>Core
> On 2017/01/18 18:21:24, Charlie Harrison wrote:
> > On 2017/01/18 18:18:50, ymzhang1 wrote:
> > > On 2017/01/18 16:53:55, eae wrote:
> > > > On 2017/01/18 10:26:32, tyoshino wrote:
> > > > > This directly contains code of various teams. So, adding only
> > > > > mailto:layout-dev@chromium.org shouldn't make much sense, I
> think.
> > > > >
> > > > > Adding eae@ to see if having layout-dev@ is ok. But still need
> to list all
> > > the
> > > > > TEAMs who have code they own here.
> > > >
> > > > No, layout-dev only owns a small fraction of the code in this
> direcotry.
> > >
> > > We will only have one component and one team for each directory or
> none (if
> > > there's no major component). Would it be better if I remove TEAM and
> COMPONENT
> > > information here?
> >
> > Yes, please remove the TEAM/COMPONENT, this directory shares code
> between many
> > teams working inside and outside Blink.
>
> Done.
>
> https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS
> File net/data/websocket/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
> net/data/websocket/OWNERS:4:
> On 2017/01/18 10:26:32, tyoshino wrote:
> > It's ok to add
> > TEAM: mailto:blink-network-stack@google.com
>
> Done.
>
>
>
https://codereview.chromium.org/2641543002/diff/1/net/data/websocket/OWNERS#n...
> net/data/websocket/OWNERS:5: # COMPONENT: Internals>Network
> On 2017/01/18 10:26:32, tyoshino wrote:
> > For now, please use Blink>Network>WebSockets.
>
> Done.
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/xmlhttprequest/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/xmlhttprequest/OWNERS:7: # COMPONENT:
> Blink>Network
> On 2017/01/18 10:26:32, tyoshino wrote:
> > Please use Blink>Network>XHR
>
> Done.
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/eventsource/OWNERS (right):
>
>
>
https://codereview.chromium.org/2641543002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/eventsource/OWNERS:5: # COMPONENT:
> Blink>Network>FetchAPI
> On 2017/01/18 10:26:32, tyoshino wrote:
> > Please use Blink>Network
>
> Done.
>
> https://codereview.chromium.org/2641543002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[tyoshino (SeeGerritForStatus), 2017-01-18 23:33:30]

Thanks eae, csharrison for help.

Thanks for the answer about the list, sshruthi, ymzhang. Got it.

Now, lgtm.

[tyoshino (SeeGerritForStatus), 2017-01-18 23:34:02]

tyoshino@chromium.org changed reviewers:
+ yhirano@chromium.org

[tyoshino (SeeGerritForStatus), 2017-01-18 23:34:23]

tyoshino@chromium.org changed reviewers:
- yhirano@chromium.org

[ymzhang1, 2017-01-18 23:40:46]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:41:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:20:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484782846307580,
"parent_rev": "5041e28550903b40c925d66f6bb5bb6a6baed15b", "commit_rev":
"c11dd43622d564f950c0d1f3e940507e32e25a87"}

[commit-bot: I haz the power, 2017-01-19 01:21:23]

Description was changed from

==========
Please help us to verify the TEAM/COMPONENT information. If the current
information is incorrect, please suggest the correct team or component or
None(if not applicable). 

BUG=679905
R=tyoshino
==========

to

==========
Please help us to verify the TEAM/COMPONENT information. If the current
information is incorrect, please suggest the correct team or component or
None(if not applicable). 

BUG=679905
R=tyoshino

Review-Url: https://codereview.chromium.org/2641543002
Cr-Commit-Position: refs/heads/master@{#444585}
Committed:
https://chromium.googlesource.com/chromium/src/+/c11dd43622d564f950c0d1f3e940...
==========

[commit-bot: I haz the power, 2017-01-19 01:21:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c11dd43622d564f950c0d1f3e940...

[kouhei (in TOK), 2017-01-20 04:37:24]

lgtm