Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2641513003: [wasm][asm.js] Check if a property key is a PropertyName before assumming it. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Check if a property key is a PropertyName before assumming it. BUG=681707 R=aseemgarg@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2641513003 Cr-Commit-Position: refs/heads/master@{#42433} Committed: https://chromium.googlesource.com/v8/v8/+/2f0891977e0b7716a078ce8675be43c16dd9ad1c

Patch Set 1 #

Patch Set 2 : Add flags #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/asm/regress-681707.js View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
bradn
3 years, 11 months ago (2017-01-17 20:50:52 UTC) #4
aseemgarg
lgtm
3 years, 11 months ago (2017-01-18 04:28:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641513003/40001
3 years, 11 months ago (2017-01-18 06:47:24 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 06:49:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2f0891977e0b7716a078ce8675be43c16dd...

Powered by Google App Engine
This is Rietveld 408576698