Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2641473002: PPC/s390: [builtins] CompileLazy bailed out to the runtime entirely too often. (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] CompileLazy bailed out to the runtime entirely too often. Port 743fdb25b3f4dd11303a5f3507dcc9578e7417e1 Original Commit Message: This is just a bug. CompileLazy knows how to look in the SharedFunctionInfo for code (or bytecode, essentially) if it finds nothing in the OptimizedCodeMap. Ensure that behavior. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=681543 LOG=N Review-Url: https://codereview.chromium.org/2641473002 Cr-Commit-Position: refs/heads/master@{#42422} Committed: https://chromium.googlesource.com/v8/v8/+/bb89869a518cb246b2c23f7e59cbbfe72e851e65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-17 16:37:26 UTC) #1
JoranSiu
On 2017/01/17 16:37:26, JaideepBajwa wrote: > ptal lgtm
3 years, 11 months ago (2017-01-17 16:44:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641473002/1
3 years, 11 months ago (2017-01-17 16:44:43 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 17:08:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bb89869a518cb246b2c23f7e59cbbfe72e8...

Powered by Google App Engine
This is Rietveld 408576698