Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2641423002: Rename TLS error assistant to SSL error assistant (Closed)

Created:
3 years, 11 months ago by meacer
Modified:
3 years, 11 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename TLS error assistant to SSL error assistant SSL is more commonly used throughout the code, so let's be consistent. BUG=640835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2641423002 Cr-Commit-Position: refs/heads/master@{#445261} Committed: https://chromium.googlesource.com/chromium/src/+/15f128c5ea64493709f984f8ac5b7edab3fc5acb

Patch Set 1 #

Patch Set 2 : More rename #

Total comments: 2

Patch Set 3 : Year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -144 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/ssl/ssl_error_assistant/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/resources/ssl/ssl_error_assistant/gen_ssl_error_assistant_proto.py View 1 2 chunks +7 lines, -8 lines 0 comments Download
A + chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ssl/tls_error_assistant/BUILD.gn View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/resources/ssl/tls_error_assistant/gen_tls_error_assistant_proto.py View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/resources/ssl/tls_error_assistant/tls_error_assistant.asciipb View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ssl/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ssl/ssl_error_assistant.proto View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ssl/tls_error_assistant.proto View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
meacer
PTAL?
3 years, 11 months ago (2017-01-20 22:14:00 UTC) #3
Nathan Parker
lgtm https://codereview.chromium.org/2641423002/diff/20001/chrome/browser/ssl/BUILD.gn File chrome/browser/ssl/BUILD.gn (right): https://codereview.chromium.org/2641423002/diff/20001/chrome/browser/ssl/BUILD.gn#newcode1 chrome/browser/ssl/BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights ...
3 years, 11 months ago (2017-01-20 23:14:52 UTC) #4
meacer
https://codereview.chromium.org/2641423002/diff/20001/chrome/browser/ssl/BUILD.gn File chrome/browser/ssl/BUILD.gn (right): https://codereview.chromium.org/2641423002/diff/20001/chrome/browser/ssl/BUILD.gn#newcode1 chrome/browser/ssl/BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 11 months ago (2017-01-21 02:24:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641423002/40001
3 years, 11 months ago (2017-01-21 02:24:54 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 03:19:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/15f128c5ea64493709f984f8ac5b...

Powered by Google App Engine
This is Rietveld 408576698