Refactor ImageBitmap to stop drawing unpremul SkImage on SkCanvas

Refactor ImageBitmap to stop drawing unpremul SkImage on SkCanvas

Skia is deprecating the use of Unpremultiplied alpha with SkImage. SkImage will still be able to store Unpremultiplied pixel values, but it will not do the right thing for drawing to an SkCanvas. ImageBitmap must be refactored to function properly after this change.

BUG=683154
Review-Url: https://codereview.chromium.org/2641393002
Cr-Commit-Position: refs/heads/master@{#445495}
Committed: https://chromium.googlesource.com/chromium/src/+/12ec50eea00c7622356d6348a88f26e140a44d02

[zakerinasab1, 2017-01-20 19:05:54]

Description was changed from

==========
Refactor ImageBitmap to stop drawing unpremul SkImage on SkCanvas

Skia is deprecating the use of Unpremultiplied alpha with SkImage. SkImage will
still be able to store Unpremultiplied pixel values, but it will not do the
right thing for drawing to an SkCanvas. ImageBitmap must be refactored to
function properly after this change.

BUG=683154
==========

to

==========
Refactor ImageBitmap to stop drawing unpremul SkImage on SkCanvas

Skia is deprecating the use of Unpremultiplied alpha with SkImage. SkImage will
still be able to store Unpremultiplied pixel values, but it will not do the
right thing for drawing to an SkCanvas. ImageBitmap must be refactored to
function properly after this change.

BUG=683154
==========

[zakerinasab1, 2017-01-20 19:05:54]

zakerinasab@google.com changed reviewers:
+ junov@chromium.org

[zakerinasab1, 2017-01-20 19:31:29]

zakerinasab@google.com changed reviewers:
+ dcheng@chromium.org

[Justin Novosad, 2017-01-23 16:26:07]

https://codereview.chromium.org/2641393002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js
(right):

https://codereview.chromium.org/2641393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js:108:
// { sub: true, bitmap: bitmaps.noFlipYUnpremul, flipY: false, premultiply:
false, colorSpace: 'empty' },
Add a comment that references a crbug for following-up on this.

[zakerinasab1, 2017-01-23 16:34:33]

zakerinasab@google.com changed reviewers:
+ zakerinasab@google.com

[zakerinasab1, 2017-01-23 16:34:33]

Comments addressed. PTAL.

[Justin Novosad, 2017-01-23 16:57:53]

On 2017/01/23 16:34:33, zakerinasab1 wrote:
> Comments addressed. PTAL.

lgtm

[dcheng, 2017-01-23 19:10:50]

rs lgtm

[zakerinasab1, 2017-01-23 19:14:12]

The CQ bit was checked by zakerinasab@google.com

[commit-bot: I haz the power, 2017-01-23 19:14:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 21:42:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485198852636110,
"parent_rev": "653f787c53cd2f9104e85dc61238d9ef25e9d347", "commit_rev":
"12ec50eea00c7622356d6348a88f26e140a44d02"}

[commit-bot: I haz the power, 2017-01-23 21:43:23]

Description was changed from

==========
Refactor ImageBitmap to stop drawing unpremul SkImage on SkCanvas

Skia is deprecating the use of Unpremultiplied alpha with SkImage. SkImage will
still be able to store Unpremultiplied pixel values, but it will not do the
right thing for drawing to an SkCanvas. ImageBitmap must be refactored to
function properly after this change.

BUG=683154
==========

to

==========
Refactor ImageBitmap to stop drawing unpremul SkImage on SkCanvas

Skia is deprecating the use of Unpremultiplied alpha with SkImage. SkImage will
still be able to store Unpremultiplied pixel values, but it will not do the
right thing for drawing to an SkCanvas. ImageBitmap must be refactored to
function properly after this change.

BUG=683154

Review-Url: https://codereview.chromium.org/2641393002
Cr-Commit-Position: refs/heads/master@{#445495}
Committed:
https://chromium.googlesource.com/chromium/src/+/12ec50eea00c7622356d6348a88f...
==========

[commit-bot: I haz the power, 2017-01-23 21:43:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/12ec50eea00c7622356d6348a88f...