Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2641323002:
Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl (Closed)
|
Created:
3 years, 11 months ago by Hwanseung Lee Modified:
3 years, 11 months ago Reviewers:
haraken CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMigrate Timer to TaskRunnerTimer in AXObjectCacheImpl.
Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl.
UnspecedTimer was choosed as TaskType.
because it is not speced task.
BUG=624694
Review-Url: https://codereview.chromium.org/2641323002
Cr-Commit-Position: refs/heads/master@{#445266}
Committed: https://chromium.googlesource.com/chromium/src/+/c3d95b718b20fad7919e64d28faf6d3a45d1a76d
Patch Set 1 #Patch Set 2 : Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl #Patch Set 3 : Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl #Patch Set 4 : Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl #Patch Set 5 : rebase #
Messages
Total messages: 35 (29 generated)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
hs1217.lee@samsung.com changed reviewers: + haraken@chromium.org
@haraken PTAL. thank you.
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
This is not a speced task, so I think we should use UnspecedTimer. Also please explain why you chose the task source in the CL description.
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
@haraken i fixed TaskType as UnspecedTimer. thank you.
Description was changed from ========== Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl BUG=624694 ========== to ========== Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl. Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl. UnspecedTimer was choosed as TaskType. because it is not speced task. BUG=624694 ==========
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484969508432240,
"parent_rev": "3d9c9a452905453d023cb1c632ee691ecbde6911", "commit_rev":
"c3d95b718b20fad7919e64d28faf6d3a45d1a76d"}
Message was sent while issue was closed.
Description was changed from ========== Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl. Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl. UnspecedTimer was choosed as TaskType. because it is not speced task. BUG=624694 ========== to ========== Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl. Migrate Timer to TaskRunnerTimer in AXObjectCacheImpl. UnspecedTimer was choosed as TaskType. because it is not speced task. BUG=624694 Review-Url: https://codereview.chromium.org/2641323002 Cr-Commit-Position: refs/heads/master@{#445266} Committed: https://chromium.googlesource.com/chromium/src/+/c3d95b718b20fad7919e64d28faf... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/c3d95b718b20fad7919e64d28faf... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
