Bypass key event suppression for PrintScreen

Bypass key event suppression for PrintScreen

Because the OS (at least Windows/Linux) handled PrintScreen only the
KeyUp event arrives in RenderWidgetHostImpl::ForwardKeyboardEvent().
Because RenderWidgetHostViewAura::OnWindowFocused() calls
SuppressEventsUntilKeyDown(), this means that the first PrintScreen
keyup event after load (or switching windows) will go missing.

This is a conservative workaround, a riskier but better fix will be to
remove the SuppressEventsUntilKeyDown() call entirely:
https://codereview.chromium.org/2643243002

BUG=668969

[foolip, 2017-01-20 11:33:32]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 11:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-01-20 11:41:10]

Description was changed from

==========
Bypass key event suppression for PrintScreen

BUG=668969
==========

to

==========
Bypass key event suppression for PrintScreen

Because the OS (at least Windows/Linux) handled PrintScreen only the
KeyUp event arrives in RenderWidgetHostImpl::ForwardKeyboardEvent().
Because RenderWidgetHostViewAura::OnWindowFocused() calls
SuppressEventsUntilKeyDown(), this means that the first PrintScreen
keyup event after load (or switching windows) will go missing.

This is a conservative workaround, a riskier but better fix will be to
remove the SuppressEventsUntilKeyDown() call entirely.

BUG=668969
==========

[foolip, 2017-01-20 11:46:47]

Description was changed from

==========
Bypass key event suppression for PrintScreen

Because the OS (at least Windows/Linux) handled PrintScreen only the
KeyUp event arrives in RenderWidgetHostImpl::ForwardKeyboardEvent().
Because RenderWidgetHostViewAura::OnWindowFocused() calls
SuppressEventsUntilKeyDown(), this means that the first PrintScreen
keyup event after load (or switching windows) will go missing.

This is a conservative workaround, a riskier but better fix will be to
remove the SuppressEventsUntilKeyDown() call entirely.

BUG=668969
==========

to

==========
Bypass key event suppression for PrintScreen

Because the OS (at least Windows/Linux) handled PrintScreen only the
KeyUp event arrives in RenderWidgetHostImpl::ForwardKeyboardEvent().
Because RenderWidgetHostViewAura::OnWindowFocused() calls
SuppressEventsUntilKeyDown(), this means that the first PrintScreen
keyup event after load (or switching windows) will go missing.

This is a conservative workaround, a riskier but better fix will be to
remove the SuppressEventsUntilKeyDown() call entirely:
https://codereview.chromium.org/2643243002

BUG=668969
==========

[commit-bot: I haz the power, 2017-01-20 12:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 12:19:09]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-01-20 12:24:32]

foolip@chromium.org changed reviewers:
+ sadrul@chromium.org

[foolip, 2017-01-20 12:24:33]

PTAL

[sadrul, 2017-01-23 18:18:35]

Do you plan on merging this back to some branch? If not, maybe we can just go
with https://codereview.chromium.org/2643243002?

https://codereview.chromium.org/2641313002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2641313002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:1212: // For
PrintScreen, a lone KeyUp event arrives. Bypass the suppression in this
Is this the case on all platforms?

[foolip, 2017-01-24 04:37:15]

On 2017/01/23 18:18:35, sadrul wrote:
> Do you plan on merging this back to some branch? If not, maybe we can just go
> with https://codereview.chromium.org/2643243002

Last week I thought there might still be a chance for M56, but I think it's too
late now. I'd still like to merge to M57, but that's just branched so I think
it's worth trying the full removal. I'll update that CL and close this one.

[foolip, 2017-01-24 04:38:12]

https://codereview.chromium.org/2641313002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2641313002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:1212: // For
PrintScreen, a lone KeyUp event arrives. Bypass the suppression in this
On 2017/01/23 18:18:35, sadrul wrote:
> Is this the case on all platforms?

I tested Windows and Linux then, on Mac there isn't a PrintScreen key and I
didn't test using an external keyboard.