Bypass key event suppression for PrintScreen

content/browser/renderer_host/render_widget_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 
 #include <math.h>
 
 #include <set>
 #include <tuple>
@@ skipping 65 matching lines @@
 #include "gpu/command_buffer/service/gpu_switches.h"
 #include "gpu/ipc/common/gpu_messages.h"
 #include "net/base/filename_util.h"
 #include "skia/ext/image_operations.h"
 #include "skia/ext/platform_canvas.h"
 #include "storage/browser/fileapi/isolated_context.h"
 #include "third_party/WebKit/public/web/WebCompositionUnderline.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/events/blink/web_input_event_traits.h"
 #include "ui/events/event.h"
+#include "ui/events/keycodes/dom/dom_code.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/gfx/color_space.h"
 #include "ui/gfx/geometry/size_conversions.h"
 #include "ui/gfx/geometry/vector2d_conversions.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/skbitmap_operations.h"
 #include "ui/snapshot/snapshot.h"
 
 #if defined(OS_ANDROID)
 #include "ui/android/view_android.h"
@@ skipping 1105 matching lines @@
     if (key_event.type() == WebKeyboardEvent::RawKeyDown)
       suppress_events_until_keydown_ = true;
     return;
   }
 
   // Double check the type to make sure caller hasn't sent us nonsense that
   // will mess up our key queue.
   if (!WebInputEvent::isKeyboardEventType(key_event.type()))
     return;
 
-  if (suppress_events_until_keydown_) {
+  // For PrintScreen, a lone KeyUp event arrives. Bypass the suppression in this

[sadrul, 2017/01/23 18:18:35]

Is this the case on all platforms?

[foolip, 2017/01/24 04:38:12]

I tested Windows and Linux then, on Mac there isn't a PrintScreen key and I
didn't test using an external keyboard.

+  // case, as a |SuppressEventsUntilKeyDown()| call otherwise causes the keyup
+  // events to go missing.
+  // TODO(foolip): Remove this special case by instead removing the
+  // |SuppressEventsUntilKeyDown()| call. https://crbug.com/668969
+  bool is_print_screen =
+      static_cast<ui::DomCode>(key_event.domCode) == ui::DomCode::PRINT_SCREEN;
+  if (suppress_events_until_keydown_ && !is_print_screen) {
     // If the preceding RawKeyDown event was handled by the browser, then we
     // need to suppress all events generated by it until the next RawKeyDown or
     // KeyDown event.
     if (key_event.type() == WebKeyboardEvent::KeyUp ||
         key_event.type() == WebKeyboardEvent::Char)
       return;
     DCHECK(key_event.type() == WebKeyboardEvent::RawKeyDown ||
            key_event.type() == WebKeyboardEvent::KeyDown);
     suppress_events_until_keydown_ = false;
   }
@@ skipping 1304 matching lines @@
     // different from the receiver's.
     file_system_file.url =
         GURL(storage::GetIsolatedFileSystemRootURIString(
                  file_system_url.origin(), filesystem_id, std::string())
                  .append(register_name));
     file_system_file.filesystem_id = filesystem_id;
   }
 }
 
 }  // namespace content