Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2641293002: Add data usage tracking for chrome services (Closed)

Created:
3 years, 11 months ago by Raj
Modified:
3 years, 11 months ago
CC:
chromium-reviews, zea+watch_chromium.org, droger+watchlist_chromium.org, Peter Beverloo, blundell+watchlist_chromium.org, johnme+watch_chromium.org, sdefresne+watchlist_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add data usage tracking for chrome services Add data usage tracking for GCM driver, web history and network time tracker services BUG=655749 Review-Url: https://codereview.chromium.org/2641293002 Cr-Commit-Position: refs/heads/master@{#445148} Committed: https://chromium.googlesource.com/chromium/src/+/bfee22ef3c7c2749538912889b26c1142530a122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M components/data_use_measurement/core/data_use_user_data.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_request.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/history/core/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/history/core/browser/web_history_service.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/network_time/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/network_time/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/network_time/network_time_tracker.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Raj
zea: ptal components/gcm_driver/* components/network_time/* sky: ptal components/history/core/browser/* rkaplow: ptal histograms.xml
3 years, 11 months ago (2017-01-20 17:58:28 UTC) #6
Nicolas Zea
gcm and network time tracker lgtm
3 years, 11 months ago (2017-01-20 18:18:54 UTC) #7
rkaplow
lgtm
3 years, 11 months ago (2017-01-20 19:37:07 UTC) #8
Raj
ryansturm: ptal components/data_use_measurement/core/*
3 years, 11 months ago (2017-01-20 19:40:30 UTC) #10
RyanSturm
-ryansturm +Tbansal I'm OOO for a few days.
3 years, 11 months ago (2017-01-20 19:57:46 UTC) #12
tbansal1
lgtm
3 years, 11 months ago (2017-01-20 20:11:13 UTC) #15
sky
LGTM
3 years, 11 months ago (2017-01-20 20:18:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641293002/1
3 years, 11 months ago (2017-01-20 20:27:16 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 20:35:00 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bfee22ef3c7c2749538912889b26...

Powered by Google App Engine
This is Rietveld 408576698