Clear Active Directory realm in case of cloud management

Clear Active Directory realm in case of cloud management

BUG=682767
TEST=manual

Review-Url: https://codereview.chromium.org/2641263004
Cr-Commit-Position: refs/heads/master@{#445394}
Committed: https://chromium.googlesource.com/chromium/src/+/bd82d6f63446b2eb210e670a0d889d076b8e4501

[Roman Sorokin (ftl), 2017-01-20 13:35:44]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 13:35:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-20 13:36:45]

rsorokin@chromium.org changed reviewers:
+ tnagel@chromium.org

[Roman Sorokin (ftl), 2017-01-20 13:36:45]

Thiemo, PTAL!

[commit-bot: I haz the power, 2017-01-20 13:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 13:59:42]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2017-01-23 13:03:52]

On 2017/01/20 13:36:45, Roman Sorokin wrote:
> Thiemo, PTAL!

I don't think this is correct.  When the user goes through the AD join UX
(entering AD credentials) they certainly don't want to enroll to cloud
management.  Thus if DM server returns non-ad management type, enrollment should
fail.

[Roman Sorokin (ftl), 2017-01-23 14:21:20]

On 2017/01/23 13:03:52, Thiemo Nagel (slow) wrote:
> On 2017/01/20 13:36:45, Roman Sorokin wrote:
> > Thiemo, PTAL!
> 
> I don't think this is correct.  When the user goes through the AD join UX
> (entering AD credentials) they certainly don't want to enroll to cloud
> management.  Thus if DM server returns non-ad management type, enrollment
should
> fail.

Make sense.

[Roman Sorokin (ftl), 2017-01-23 14:21:32]

Thiemo, PTAL.

[Thiemo Nagel, 2017-01-23 16:44:23]

Lgtm.  Looks like a good candidate for merging to M-57 to me.

[Roman Sorokin (ftl), 2017-01-23 16:45:34]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:45:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 17:12:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485189934406310,
"parent_rev": "cc2c85c51df265ff8ab049b080ff89910afe45f8", "commit_rev":
"bd82d6f63446b2eb210e670a0d889d076b8e4501"}

[commit-bot: I haz the power, 2017-01-23 17:13:40]

Description was changed from

==========
Clear Active Directory realm in case of cloud management

BUG=682767
TEST=manual
==========

to

==========
Clear Active Directory realm in case of cloud management

BUG=682767
TEST=manual

Review-Url: https://codereview.chromium.org/2641263004
Cr-Commit-Position: refs/heads/master@{#445394}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd82d6f63446b2eb210e670a0d88...
==========

[commit-bot: I haz the power, 2017-01-23 17:13:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bd82d6f63446b2eb210e670a0d88...