components/rappor/proto/rappor_metric.proto - Issue 264123004: Modify rappor parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/rappor/proto/rappor_metric.proto

Issue 264123004: Modify rappor parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert platform/os part, modify metric names. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/rappor/proto/rappor_metric.proto

diff --git a/components/rappor/proto/rappor_metric.proto b/components/rappor/proto/rappor_metric.proto

index e5efe21c4779b98dcc5128f273a0d9bf3999fe58..49098eb45bfde8f275df3c4ebc6a1a31f7dc23d8 100644

--- a/components/rappor/proto/rappor_metric.proto

+++ b/components/rappor/proto/rappor_metric.proto

@@ -20,7 +20,7 @@ message RapporReports {

// partioned into cohorts in different ways, to allow better statistics and

// increased coverage. In particular, the cohort will serve to choose the

// hash functions used for Bloom-filter-based reports. The cohort is

- // generated randomly by the client and is currently in the range [0,32).

+ // generated randomly by the client and is currently in the range [0,512).

Alexei Svitkine (slow) 2014/05/20 06:59:49 Hmm, should we mention when this changed? (i.e. Ch

Steven Holte 2014/05/20 22:53:53 Not sure how to predict the specific chrome versio

optional int32 cohort = 1;

// Each Report contains the values generated by the RAPPOR process for one