components/rappor/rappor_metric.cc - Issue 264123004: Modify rappor parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/rappor/rappor_metric.cc

Issue 264123004: Modify rappor parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert platform/os part, modify metric names. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/rappor/rappor_metric.cc

diff --git a/components/rappor/rappor_metric.cc b/components/rappor/rappor_metric.cc

index f8ff16252e232ddbdbd258e6f337ed20b3d124f2..b4bd950af9d1741210b81dcdf54bbd893b1b63b2 100644

--- a/components/rappor/rappor_metric.cc

+++ b/components/rappor/rappor_metric.cc

@@ -10,13 +10,15 @@ namespace rappor {

RapporMetric::RapporMetric(const std::string& metric_name,

const RapporParameters& parameters,

- int32_t cohort)

+ int32_t cohort_seed)

: metric_name_(metric_name),

parameters_(parameters),

bloom_filter_(parameters.bloom_filter_size_bytes,

parameters.bloom_filter_hash_function_count,

- cohort * parameters.bloom_filter_hash_function_count) {

- DCHECK_GE(cohort, 0);

+ (cohort_seed % parameters.num_cohorts) *

+ parameters.bloom_filter_hash_function_count) {

+ DCHECK_GE(cohort_seed, 0);

+ DCHECK_LT(cohort_seed, RapporParameters::kMaxCohorts);

}

RapporMetric::~RapporMetric() {}