Issue 28100. In strong mode verify that TypeParameter bound has required type arguments.

Issue 28100. In strong mode verify that TypeParameter bound has required type arguments.

R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/28100

Committed: https://github.com/dart-lang/sdk/commit/c7487dfaea1f0938385701aa062763e0f26747ad

[Brian Wilkerson, 2017-01-19 19:27:04]

lgtm

[scheglov, 2017-01-19 21:25:55]

Description was changed from

==========
Issue 28100. In strong mode verify that TypeParameter bound has required type
arguments.

R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/28100
==========

to

==========
Issue 28100. In strong mode verify that TypeParameter bound has required type
arguments.

R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/28100

Committed:
https://github.com/dart-lang/sdk/commit/c7487dfaea1f0938385701aa062763e0f26747ad
==========

[scheglov, 2017-01-19 21:25:56]

Committed patchset #1 (id:1) manually as
c7487dfaea1f0938385701aa062763e0f26747ad (presubmit successful).

[Leaf, 2017-01-20 01:43:16]

https://codereview.chromium.org/2641213002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2641213002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:5207: if (type is
InterfaceType && type.element.typeParameters.isNotEmpty) {
I don't think this handles nested types.  This perhaps should have been made
more clear in the proposal, but the intent with proposal 2 is that all types in
the bound need to be instantiated.  I think this check here still allows

class A<T extends List<List>> {}

[scheglov, 2017-01-20 15:36:26]

https://codereview.chromium.org/2641213002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2641213002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:5207: if (type is
InterfaceType && type.element.typeParameters.isNotEmpty) {
On 2017/01/20 01:43:16, Leaf wrote:
> I don't think this handles nested types.  This perhaps should have been made
> more clear in the proposal, but the intent with proposal 2 is that all types
in
> the bound need to be instantiated.  I think this check here still allows
> 
> class A<T extends List<List>> {}

ACK.
https://codereview.chromium.org/2646983003 will fix this.