Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2646983003: Issue 28100. Fix for indirect not instantiated types, tests. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 28100. Fix for indirect not instantiated types, tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f550374a6b49a9221b659ac1e3e27af60aa27e89

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +12 lines, -7 lines 2 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 11 months ago (2017-01-20 15:35:53 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2646983003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/2646983003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode5205 pkg/analyzer/lib/src/generated/error_verifier.dart:5205: if (node is TypeName) { For GenericFunctionType I ...
3 years, 11 months ago (2017-01-20 15:41:58 UTC) #2
scheglov
https://codereview.chromium.org/2646983003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/2646983003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode5205 pkg/analyzer/lib/src/generated/error_verifier.dart:5205: if (node is TypeName) { On 2017/01/20 15:41:58, Brian ...
3 years, 11 months ago (2017-01-20 16:05:44 UTC) #3
scheglov
3 years, 11 months ago (2017-01-20 16:07:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f550374a6b49a9221b659ac1e3e27af60aa27e89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698