Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2641173009: Add BluetoothRemoteGATTDescriptor reporting for .readValue(). (Closed)

Created:
3 years, 11 months ago by dougt
Modified:
3 years, 10 months ago
Reviewers:
ortuno, Ilya Sherman
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add BluetoothRemoteGATTDescriptor reporting for .readValue(). Similar to reporting for characteristic.readValue(), this cl will add outcome reporting for descriptor.readValue allowing us to better understand how common errors in the field happen. BUG=667319 R= Review-Url: https://codereview.chromium.org/2641173009 Cr-Commit-Position: refs/heads/master@{#446644} Committed: https://chromium.googlesource.com/chromium/src/+/4848d4718a80dbd05337efca0528fd189a1a56b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M content/browser/bluetooth/bluetooth_metrics.h View 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/bluetooth/bluetooth_metrics.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 4 chunks +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
dougt
isherman, ptal at tools/metrics/histograms/histograms.xml ortuno, ptal.
3 years, 11 months ago (2017-01-24 00:30:49 UTC) #6
ortuno
lgtm
3 years, 11 months ago (2017-01-24 00:38:38 UTC) #7
Ilya Sherman
Metrics LGTM
3 years, 11 months ago (2017-01-24 01:00:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641173009/1
3 years, 11 months ago (2017-01-27 07:12:38 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 11:07:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4848d4718a80dbd05337efca0528...

Powered by Google App Engine
This is Rietveld 408576698