Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2641173008: [SPv2] Add CSS mask support (Closed)
Patch Set: update layout test expectation && add unit tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index c86eecd23bcb11405ff93ff668cc7856c6edd9dd..aa36e2a73c8e65bf52ec7bad249a1ac2a4d64c5d 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -2651,7 +2651,10 @@ void PaintLayer::setGroupedMapping(CompositedLayerMapping* groupedMapping,
groupedMapping->setNeedsGraphicsLayerUpdate(GraphicsLayerUpdateSubtree);
}
-bool PaintLayer::hasCompositedMask() const {
+bool PaintLayer::maskBlendingAppliedByCompositor() const {
chrishtr 2017/02/11 23:55:11 In SPv2 mode, it's not really "applied by composit
trchen 2017/02/13 21:12:02 The property tree is the representation of the eff
chrishtr 2017/02/13 23:23:49 ok
+ DCHECK(m_layoutObject->hasMask());
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+ return true;
return m_rareData && m_rareData->compositedLayerMapping &&
m_rareData->compositedLayerMapping->hasMaskLayer();
}

Powered by Google App Engine
This is Rietveld 408576698