Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 264113002: Revert 268199 "Add real file for AdNetworks DB" (Closed)

Created:
6 years, 7 months ago by benjhayden
Modified:
6 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 268199 "Add real file for AdNetworks DB" > Add real file for AdNetworks DB > > This adds the real hash file for the ad_networks.dat file. The implementation > for the database went in last week, and seems to be stable. > > Follows: https://codereview.chromium.org/242303002/ > > notry'ing, since it's a pure binary change. > > BUG=357204 > NOTRY=true > > Review URL: https://codereview.chromium.org/268063004 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M trunk/src/chrome/browser/resources/ad_networks.dat View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benjhayden
6 years, 7 months ago (2014-05-05 17:29:57 UTC) #1
benjhayden
Committed patchset #1 manually as r268209 (tree was closed).
6 years, 7 months ago (2014-05-05 17:30:11 UTC) #2
Lei Zhang
Can you include a message to explain why this was reverted? FYI, this might have ...
6 years, 7 months ago (2014-05-05 20:56:30 UTC) #3
Lei Zhang
On 2014/05/05 20:56:30, Lei Zhang wrote: > Can you include a message to explain why ...
6 years, 7 months ago (2014-05-05 20:56:58 UTC) #4
benjhayden
6 years, 7 months ago (2014-05-05 21:03:48 UTC) #5
Message was sent while issue was closed.
Sorry, I should remember to comment on reverts.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x5f6ecb in operator new(unsigned long)
/usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x833d58d in LoadDataResourceBytesForScale
ui/base/resource/resource_bundle.cc:412
    #2 0x833d58d in ui::ResourceBundle::LoadDataResourceBytes(int) const
ui/base/resource/resource_bundle.cc:398
    #3 0xe2c5293 in Init
chrome/browser/extensions/activity_log/ad_network_database.cc:57
    #4 0xe2c5293 in AdNetworkDatabaseImpl
chrome/browser/extensions/activity_log/ad_network_database.cc:50
    #5 0xe2c5293 in Get
chrome/browser/extensions/activity_log/ad_network_database.cc:124
    #6 0xe2c5293 in extensions::AdNetworkDatabase::Get()
chrome/browser/extensions/activity_log/ad_network_database.cc:143
    #7 0xe2ac95b in extensions::Action::DidInjectAd(rappor::RapporService*)
const chrome/browser/extensions/activity_log/activity_actions.cc:160
    #8 0xe2e2592 in
extensions::UmaPolicy::MatchActionToStatus(scoped_refptr<extensions::Action>)
chrome/browser/extensions/activity_log/uma_policy.cc:147
    #9 0xe2e1b2f in
extensions::UmaPolicy::ProcessAction(scoped_refptr<extensions::Action>)
chrome/browser/extensions/activity_log/uma_policy.cc:77

Powered by Google App Engine
This is Rietveld 408576698