Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 268063004: Add real file for AdNetworks DB (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
James Hawkins, felt
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Add real file for AdNetworks DB This adds the real hash file for the ad_networks.dat file. The implementation for the database went in last week, and seems to be stable. Follows: https://codereview.chromium.org/242303002/ notry'ing, since it's a pure binary change. BUG=357204 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/browser/resources/ad_networks.dat View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Adrienne, FYI. James, per comment in https://codereview.chromium.org/242303002/, this is the full file. Size ~4kb, as ...
6 years, 7 months ago (2014-05-05 16:30:25 UTC) #1
James Hawkins
lgtm
6 years, 7 months ago (2014-05-05 16:31:10 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-05 16:33:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/268063004/1
6 years, 7 months ago (2014-05-05 16:34:15 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 16:46:21 UTC) #5
Message was sent while issue was closed.
Change committed as 268199

Powered by Google App Engine
This is Rietveld 408576698