Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2641123004: [sql] Lower SQLITE_PRINTF_PRECISION_LIMIT for fuzzer. (Closed)

Created:
3 years, 11 months ago by Scott Hess - ex-Googler
Modified:
3 years, 11 months ago
Reviewers:
mmoroz
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Lower SQLITE_PRINTF_PRECISION_LIMIT for fuzzer. Real-world usage should never involve precisions above maybe 100. The previous limit of 128M makes it very easy to blow out memory when fuzzing, and since OOM is already fatal, I'm not sure that such a large limit provides any productive coverage beyond something more reasonable. BUG=665292 R=mmoroz@chromium.org Review-Url: https://codereview.chromium.org/2641123004 Cr-Commit-Position: refs/heads/master@{#445080} Committed: https://chromium.googlesource.com/chromium/src/+/9b1279144e1a29b56992dd6e5bf233f5889cc583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/sqlite/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Scott Hess - ex-Googler
3 years, 11 months ago (2017-01-19 21:58:43 UTC) #2
Scott Hess - ex-Googler
SQLITE_PRINTF_PRECISION_LIMIT from 128,000,000 to 1,280,000. [Now I'm thinking "Why not 1,000,000", but whatever.]
3 years, 11 months ago (2017-01-19 21:59:57 UTC) #4
mmoroz
LGTM 1,280,000 is kind of mysterious comparing to 1M, I like it! :) Thanks Scott!
3 years, 11 months ago (2017-01-20 09:36:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641123004/1
3 years, 11 months ago (2017-01-20 17:06:07 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 17:10:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b1279144e1a29b56992dd6e5bf2...

Powered by Google App Engine
This is Rietveld 408576698