Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2641083002: Implements CSSPropertyAPI for letter and word spacing (Closed)
Patch Set: rebase update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index 4d2a0af2272f7b3c8d53ffab2d73e2868fdd845d..3eb1f16f7a085432ca83bd53cfb9114061591ecc 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -516,15 +516,6 @@ static CSSValueList* consumeFontFamily(CSSParserTokenRange& range) {
return list;
}
-static CSSValue* consumeSpacing(CSSParserTokenRange& range,
- CSSParserMode cssParserMode) {
- if (range.peek().id() == CSSValueNormal)
- return consumeIdent(range);
- // TODO(timloh): allow <percentage>s in word-spacing.
- return consumeLength(range, cssParserMode, ValueRangeAll,
- UnitlessQuirk::Allow);
-}
-
static CSSValue* consumeFontSize(
CSSParserTokenRange& range,
CSSParserMode cssParserMode,
@@ -2826,9 +2817,6 @@ const CSSValue* CSSPropertyParser::parseSingleValue(
return consumeFontFamily(m_range);
case CSSPropertyFontWeight:
return consumeFontWeight(m_range);
- case CSSPropertyLetterSpacing:
- case CSSPropertyWordSpacing:
- return consumeSpacing(m_range, m_context->mode());
case CSSPropertyFontSize:
return consumeFontSize(m_range, m_context->mode(), UnitlessQuirk::Allow);
case CSSPropertyLineHeight:

Powered by Google App Engine
This is Rietveld 408576698