Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java

Issue 2641043002: Implement detaching the TabModelSelector from the CompositorViewHolder (Closed)
Patch Set: Fix compile Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
index 5c2334668157e0de1c6988ce1194a461481cfda7..2f1fcc4911ea6a472b47709b37072317675a99a7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
@@ -11,6 +11,7 @@ import com.google.vr.ndk.base.AndroidCompat;
import org.chromium.base.Log;
import org.chromium.base.annotations.UsedByReflection;
+import org.chromium.chrome.browser.compositor.CompositorViewHolder;
/**
* Builder class to create all VR related classes. These VR classes are behind the same build time
@@ -40,10 +41,10 @@ public class VrClassesWrapperImpl implements VrClassesWrapper {
}
@Override
- public VrShell createVrShell() {
+ public VrShell createVrShell(CompositorViewHolder compositorViewHolder) {
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
try {
- return new VrShellImpl(mActivity);
+ return new VrShellImpl(mActivity, compositorViewHolder);
} catch (Exception ex) {
Log.e(TAG, "Unable to instantiate VrShellImpl", ex);
return null;

Powered by Google App Engine
This is Rietveld 408576698