chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java - Issue 2641043002: Implement detaching the TabModelSelector from the CompositorViewHolder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java

Issue 2641043002: Implement detaching the TabModelSelector from the CompositorViewHolder (Closed)

Patch Set: Fix compile Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerHost.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java

index 4bc683df2b3a12d916c3db22de1dd51630bdd7c5..b8704e2a8d727b5d58b8625f111f6569a11364a7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java

@@ -4,6 +4,8 @@

package org.chromium.chrome.browser.vr_shell;

+import org.chromium.chrome.browser.compositor.CompositorViewHolder;

/**

* Abstracts away the VrClassesWrapperImpl class, which may or may not be present at runtime

* depending on compile flags.

@@ -17,7 +19,7 @@ public interface VrClassesWrapper {

/**

* Creates a VrShellImpl instance.

- public VrShell createVrShell();

+ public VrShell createVrShell(CompositorViewHolder compositorViewHolder);

/**

* Creates a VrDaydreamApImpl instance.