Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2641003005: Move MediaKeys timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken, jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MediaKeys timer to frame-specific TaskRunnerTimer. Move MediaKeys timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's MiscPlatformAPI timer task queue. The spec does not explicitly specify what task source it should use.[1] [1] The spec link: https://w3c.github.io/encrypted-media/#idl-def-mediakeys This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2641003005 Cr-Commit-Position: refs/heads/master@{#445923} Committed: https://chromium.googlesource.com/chromium/src/+/2d768703338ba02209fff286cf0859fb6f6e0bcc

Patch Set 1 #

Patch Set 2 : Move MediaKeys timer to frame-specific TaskRunnerTimer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-19 19:28:37 UTC) #4
haraken
Would you explain why you chose the TaskType in the CL description? It will require ...
3 years, 11 months ago (2017-01-20 05:00:34 UTC) #7
Byoungkwon Ko
I think i misunderstood between MiscPlatformAPI and UnspecedTimer. As you told it, it is a ...
3 years, 11 months ago (2017-01-20 22:51:05 UTC) #9
haraken
LGTM
3 years, 11 months ago (2017-01-21 01:30:53 UTC) #14
haraken
+jrummell FYI
3 years, 11 months ago (2017-01-21 01:31:39 UTC) #16
jrummell
lgtm
3 years, 11 months ago (2017-01-25 00:44:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641003005/20001
3 years, 11 months ago (2017-01-25 00:49:01 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 03:05:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d768703338ba02209fff286cf08...

Powered by Google App Engine
This is Rietveld 408576698