Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2641003004: Move EventSource timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move EventSource timer to frame-specific TaskRunnerTimer. Move EventSource timer m_connectTimer to frame-specific TaskRunnerTimer. This associates it with the frame's RemoteEvent timer task queue. "The task source for any tasks that are queued by EventSource objects is the remote event task source."[1] [1] The spec link: https://html.spec.whatwg.org/#sse-processing-model This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2641003004 Cr-Commit-Position: refs/heads/master@{#444999} Committed: https://chromium.googlesource.com/chromium/src/+/ea52f748a72ae7bb2a0f0286bf66a021b622fe9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/eventsource/EventSource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-19 19:28:10 UTC) #4
haraken
LGTM Would you add a link to the spec in the CL description? https://html.spec.whatwg.org/#sse-processing-model "The ...
3 years, 11 months ago (2017-01-20 05:03:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641003004/1
3 years, 11 months ago (2017-01-20 06:18:19 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 06:23:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea52f748a72ae7bb2a0f0286bf66...

Powered by Google App Engine
This is Rietveld 408576698