Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6645)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 2641003002: Show scheme in black and content in gray for data: protocol urls (Closed)
Patch Set: Update iOS Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
index 18c18df08bfac0979d2a6ab525ac1e86d0e4c951..75e6857e145f51d8d4f1caece25dd3d28a69c71c 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
@@ -184,6 +184,12 @@ class OmniboxViewMac : public OmniboxView,
void ApplyTextAttributes(const base::string16& display_text,
NSMutableAttributedString* attributedString);
+ // Update colors in |attributing_display_string_|.
Peter Kasting 2017/03/01 02:39:10 Nit: Descriptive, not imperative (e.g. "Updates");
elawrence 2017/03/01 21:49:01 Removed
+ void SetEmphasis(bool emphasize, gfx::Range range) override;
+
+ // Update color and font for scheme in |attributing_display_string_|.
+ void UpdateSchemeEmphasis(gfx::Range scheme_range) override;
+
// Return the number of UTF-16 units in the current buffer, excluding the
// suggested text.
int GetOmniboxTextLength() const override;
@@ -231,6 +237,10 @@ class OmniboxViewMac : public OmniboxView,
// The time when OnBeforeDrawRect() was called.
base::TimeTicks draw_rect_start_time_;
+ // Temporary pointer to the attributed display string, stored as color and
+ // other emphasis attributes are applied by the superclass.
+ NSMutableAttributedString* attributing_display_string_;
Robert Sesek 2017/03/01 18:29:45 Who owns this? Either document as "Weak" or put in
elawrence 2017/03/01 21:49:01 Documented as weak.
+
DISALLOW_COPY_AND_ASSIGN(OmniboxViewMac);
};

Powered by Google App Engine
This is Rietveld 408576698