Show scheme in black and content in gray for data: protocol urls

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_VIEW_MAC_H_
 #define CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_VIEW_MAC_H_
 
 #import <Cocoa/Cocoa.h>
 #include <stddef.h>
 
@@ skipping 166 matching lines @@
   void EmphasizeURLComponents() override;
 
   // Apply our font and paragraph style to |attributedString|.
   void ApplyTextStyle(NSMutableAttributedString* attributedString);
 
   // Calculates text attributes according to |display_text| and applies them
   // to the given |attributedString| object.
   void ApplyTextAttributes(const base::string16& display_text,
                            NSMutableAttributedString* attributedString);
 
+  // Update colors in |attributing_display_string_|.

[Peter Kasting, 2017/03/01 02:39:10]

Nit: Descriptive, not imperative (e.g. "Updates"); see
http://google.github.io/styleguide/cppguide.html#Function_Comments .  (2 places)

[elawrence, 2017/03/01 21:49:01]

Removed

+  void SetEmphasis(bool emphasize, gfx::Range range) override;
+
+  // Update color and font for scheme in |attributing_display_string_|.
+  void UpdateSchemeEmphasis(gfx::Range scheme_range) override;
+
   // Return the number of UTF-16 units in the current buffer, excluding the
   // suggested text.
   int GetOmniboxTextLength() const override;
   NSUInteger GetTextLength() const;
 
   // Returns true if the caret is at the end of the content.
   bool IsCaretAtEnd() const;
 
   // Announce that an inline autocomplete is available for screenreaders.
   void AnnounceAutocompleteForScreenReader(const base::string16& text);
@@ skipping 27 matching lines @@
   bool do_coalesced_range_update_;
   NSRange coalesced_range_update_;
 
   // The time of the first character insert operation that has not yet been
   // painted. Used to measure omnibox responsiveness with a histogram.
   base::TimeTicks insert_char_time_;
 
   // The time when OnBeforeDrawRect() was called.
   base::TimeTicks draw_rect_start_time_;
 
+  // Temporary pointer to the attributed display string, stored as color and
+  // other emphasis attributes are applied by the superclass.
+  NSMutableAttributedString* attributing_display_string_;

[Robert Sesek, 2017/03/01 18:29:45]

Who owns this? Either document as "Weak" or put in a scoped_nsobject.

[elawrence, 2017/03/01 21:49:01]

Documented as weak.

+
   DISALLOW_COPY_AND_ASSIGN(OmniboxViewMac);
 };
 
 #endif  // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_VIEW_MAC_H_