Use the correct version of movq for ExternalReference in X64

Use the correct version of movq for ExternalReference in X64

R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17351

[haitao.feng, 2013-10-16 12:37:16]

As ExternalReference is 32-bit in X32. PTAL.

[haitao.feng, 2013-10-17 06:11:47]

Uploaded patchset 2 and add ulan as a reviewer.

https://codereview.chromium.org/26410004/diff/10001/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):

https://codereview.chromium.org/26410004/diff/10001/src/x64/assembler-x64.cc#...
src/x64/assembler-x64.cc:1468: ASSERT(RelocInfo::IsNone(rmode));
I will submit a CL to move the movq(Register dst, int64_t value, ,
RelocInfo::Mode rmode) into X64 macro assembler and drop the relocation info
mode parameter.

For the movq(Register dst, void* value, RelocInfo::Mode rmode), the rmode could
be EXTERNAL_REFERENCE or NONE64, it is NONE64 for SMIs or Failures as they will
not be relocated. I will check each NONE64 occurrence to make sure they use the
right function.

[danno, 2013-10-23 13:16:09]

lgtm

https://codereview.chromium.org/26410004/diff/10001/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):

https://codereview.chromium.org/26410004/diff/10001/src/x64/assembler-x64.cc#...
src/x64/assembler-x64.cc:1468: ASSERT(RelocInfo::IsNone(rmode));
On 2013/10/17 06:11:48, haitao.feng wrote:
> I will submit a CL to move the movq(Register dst, int64_t value, ,
> RelocInfo::Mode rmode) into X64 macro assembler and drop the relocation info
> mode parameter.
> 
> For the movq(Register dst, void* value, RelocInfo::Mode rmode), the rmode
could
> be EXTERNAL_REFERENCE or NONE64, it is NONE64 for SMIs or Failures as they
will
> not be relocated. I will check each NONE64 occurrence to make sure they use
the
> right function.

Done.

[haitao.feng, 2013-10-24 01:28:03]

Committed patchset #2 manually as r17351 (presubmit successful).