Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 26410004: Use the correct version of movq for ExternalReference in X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Drop relocation information mode parameter from emitq" Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/x64/assembler-x64.cc ('K') | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 cmpb(Operand(rax, 0), Immediate(0)); 733 cmpb(Operand(rax, 0), Immediate(0));
734 j(zero, &profiler_disabled); 734 j(zero, &profiler_disabled);
735 735
736 // Third parameter is the address of the actual getter function. 736 // Third parameter is the address of the actual getter function.
737 movq(thunk_last_arg, function_address, RelocInfo::EXTERNAL_REFERENCE); 737 movq(thunk_last_arg, function_address, RelocInfo::EXTERNAL_REFERENCE);
738 movq(rax, thunk_address, RelocInfo::EXTERNAL_REFERENCE); 738 movq(rax, thunk_address, RelocInfo::EXTERNAL_REFERENCE);
739 jmp(&end_profiler_check); 739 jmp(&end_profiler_check);
740 740
741 bind(&profiler_disabled); 741 bind(&profiler_disabled);
742 // Call the api function! 742 // Call the api function!
743 movq(rax, reinterpret_cast<int64_t>(function_address), 743 movq(rax, reinterpret_cast<Address>(function_address),
744 RelocInfo::EXTERNAL_REFERENCE); 744 RelocInfo::EXTERNAL_REFERENCE);
745 745
746 bind(&end_profiler_check); 746 bind(&end_profiler_check);
747 747
748 // Call the api function! 748 // Call the api function!
749 call(rax); 749 call(rax);
750 750
751 if (FLAG_log_timer_events) { 751 if (FLAG_log_timer_events) {
752 FrameScope frame(this, StackFrame::MANUAL); 752 FrameScope frame(this, StackFrame::MANUAL);
753 PushSafepointRegisters(); 753 PushSafepointRegisters();
(...skipping 4214 matching lines...) Expand 10 before | Expand all | Expand 10 after
4968 movq(arg_reg_1, isolate, RelocInfo::EXTERNAL_REFERENCE); 4968 movq(arg_reg_1, isolate, RelocInfo::EXTERNAL_REFERENCE);
4969 CallCFunction( 4969 CallCFunction(
4970 ExternalReference::record_object_allocation_function(isolate), 3); 4970 ExternalReference::record_object_allocation_function(isolate), 3);
4971 PopSafepointRegisters(); 4971 PopSafepointRegisters();
4972 } 4972 }
4973 4973
4974 4974
4975 } } // namespace v8::internal 4975 } } // namespace v8::internal
4976 4976
4977 #endif // V8_TARGET_ARCH_X64 4977 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/x64/assembler-x64.cc ('K') | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698