Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2640963002: LocalFileSystem::deleteFileSystem() is no longer used. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
kinuko, haraken, nhiroki
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LocalFileSystem::deleteFileSystem() is no longer used. This method stopped being used when DevTools retired its FileSystem API support (crbug.com/588817); follow through and remove the unused implementation. R=nhiroki,kinuko,haraken BUG= Review-Url: https://codereview.chromium.org/2640963002 Cr-Commit-Position: refs/heads/master@{#444667} Committed: https://chromium.googlesource.com/chromium/src/+/89c75b9f202b8d2e749f50c8ee84e8f65d30cd42

Patch Set 1 #

Patch Set 2 : remove more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -95 lines) Patch
M content/browser/fileapi/fileapi_message_filter.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 3 chunks +0 lines, -20 lines 0 comments Download
M content/child/fileapi/file_system_dispatcher.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/fileapi/file_system_dispatcher.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
sof
While going over some Supplement<> details, i noticed this method & implementation was entirely unused ...
3 years, 11 months ago (2017-01-18 21:27:16 UTC) #8
haraken
LGTM
3 years, 11 months ago (2017-01-18 23:15:57 UTC) #9
kinuko
This was for devtools implementation which was removed sometime ago. lgtm
3 years, 11 months ago (2017-01-18 23:23:38 UTC) #10
nhiroki
lgtm
3 years, 11 months ago (2017-01-19 00:05:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640963002/20001
3 years, 11 months ago (2017-01-19 06:37:04 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 06:42:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/89c75b9f202b8d2e749f50c8ee84...

Powered by Google App Engine
This is Rietveld 408576698