Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2640923006: Cleanup CPDF_StructElement. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 10 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup CPDF_StructElement. Pre-cursor to properly ref-counting it. Rename to match the CPDF_/IPDF_ conventions. Move CPDF_ structure out of IPDF-defining headers. Break friendships. Review-Url: https://codereview.chromium.org/2640923006 Committed: https://pdfium.googlesource.com/pdfium/+/0370d6b8aab1b7880dd2727e7d9aed04cc358360

Patch Set 1 : Mechanical rename happens first. #

Patch Set 2 : second rename #

Patch Set 3 : break friendship #

Patch Set 4 : Make CPDF_StructKid private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -113 lines) Patch
M core/fpdfdoc/doc_tagged.cpp View 1 2 3 13 chunks +63 lines, -64 lines 0 comments Download
M core/fpdfdoc/fpdf_tagged.h View 1 2 3 2 chunks +1 line, -25 lines 0 comments Download
M core/fpdfdoc/tagged_int.h View 1 2 3 3 chunks +44 lines, -21 lines 0 comments Download
M fpdfsdk/fpdf_structtree.cpp View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Tom Sepez
Dan, for review.
3 years, 10 months ago (2017-01-26 19:50:54 UTC) #3
dsinclair
lgtm
3 years, 10 months ago (2017-01-26 19:57:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640923006/60001
3 years, 10 months ago (2017-01-26 20:14:32 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 20:15:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/0370d6b8aab1b7880dd2727e7d9aed04cc35...

Powered by Google App Engine
This is Rietveld 408576698