Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2640913002: Use TaskRunnerTimer in ResourceFetcher (Closed)

Created:
3 years, 11 months ago by Charlie Harrison
Modified:
3 years, 11 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskRunnerTimer in ResourceFetcher Blocker for the per-frame scheduler. BUG=624694 Review-Url: https://codereview.chromium.org/2640913002 Cr-Commit-Position: refs/heads/master@{#444648} Committed: https://chromium.googlesource.com/chromium/src/+/93a0a8f1524c0f8bbfefb7fb7a2e7ce336c22480

Patch Set 1 #

Patch Set 2 : Null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Charlie Harrison
tyoshino: PTAL? Feel free to hold off until the great fetch/ move lands.
3 years, 11 months ago (2017-01-18 17:04:37 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm
3 years, 11 months ago (2017-01-19 04:31:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640913002/20001
3 years, 11 months ago (2017-01-19 04:57:46 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 05:05:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93a0a8f1524c0f8bbfefb7fb7a2e...

Powered by Google App Engine
This is Rietveld 408576698