Enable more unittests for BlueZ and ChromeOS.

Enable more unittests for BlueZ and ChromeOS.

This patch fixes an issue with the DBUS naming needed for the generic unittests.
This again made it possible to enable a couple of more tests for BlueZ and
ChromeOS.

Review-Url: https://codereview.chromium.org/2640883002
Cr-Commit-Position: refs/heads/master@{#445117}
Committed: https://chromium.googlesource.com/chromium/src/+/dc8295b709e8c0e2ce9302501cb9a15358149824

[perja, 2017-01-18 15:44:21]

The CQ bit was checked by perja@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 15:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 16:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 16:43:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[perja, 2017-01-19 08:05:52]

The CQ bit was checked by perja@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 08:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 08:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 08:27:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[perja, 2017-01-19 08:58:27]

The CQ bit was checked by perja@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 08:59:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 09:24:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 09:24:33]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[perja, 2017-01-19 10:51:54]

The CQ bit was checked by perja@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 10:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 11:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 11:13:01]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[perja, 2017-01-19 12:46:44]

Patchset #4 (id:60001) has been deleted

[perja, 2017-01-19 12:46:50]

Patchset #3 (id:40001) has been deleted

[perja, 2017-01-19 12:46:59]

Patchset #2 (id:20001) has been deleted

[perja, 2017-01-19 12:53:27]

The CQ bit was checked by perja@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 12:53:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 13:10:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 13:10:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[perja, 2017-01-19 13:42:43]

Patchset #2 (id:80001) has been deleted

[perja, 2017-01-19 13:48:17]

The CQ bit was checked by perja@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 13:48:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:57:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:57:14]

Dry run: This issue passed the CQ dry run.

[perja, 2017-01-20 08:01:42]

perja@opera.com changed reviewers:
+ scheib@chromium.org

[perja, 2017-01-20 08:01:42]

scheib@: PTAL.

This patch fixes an issue with the DBUS naming needed for the generic unittests.
This again made it possible to enable a couple of more tests for BlueZ and
ChromeOS.

[scheib, 2017-01-20 17:57:34]

Description was changed from

==========
Enable more unittests for BlueZ and ChromeOS.
==========

to

==========
Enable more unittests for BlueZ and ChromeOS.

This patch fixes an issue with the DBUS naming needed for the generic unittests.
This again made it possible to enable a couple of more tests for BlueZ and
ChromeOS.
==========

[scheib, 2017-01-20 17:57:50]

LGTM

[scheib, 2017-01-20 17:57:56]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2017-01-20 17:58:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 19:06:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484935076036410,
"parent_rev": "ac1a85217d72b0043dfb41b447afe4f05d0d5588", "commit_rev":
"dc8295b709e8c0e2ce9302501cb9a15358149824"}

[commit-bot: I haz the power, 2017-01-20 19:06:36]

Description was changed from

==========
Enable more unittests for BlueZ and ChromeOS.

This patch fixes an issue with the DBUS naming needed for the generic unittests.
This again made it possible to enable a couple of more tests for BlueZ and
ChromeOS.
==========

to

==========
Enable more unittests for BlueZ and ChromeOS.

This patch fixes an issue with the DBUS naming needed for the generic unittests.
This again made it possible to enable a couple of more tests for BlueZ and
ChromeOS.

Review-Url: https://codereview.chromium.org/2640883002
Cr-Commit-Position: refs/heads/master@{#445117}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc8295b709e8c0e2ce9302501cb9...
==========

[commit-bot: I haz the power, 2017-01-20 19:06:37]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/dc8295b709e8c0e2ce9302501cb9...

[ortuno, 2017-01-22 20:51:54]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2017-01-22 20:51:55]

https://codereview.chromium.org/2640883002/diff/100001/device/bluetooth/test/...
File device/bluetooth/test/bluetooth_test_bluez.cc (right):

https://codereview.chromium.org/2640883002/diff/100001/device/bluetooth/test/...
device/bluetooth/test/bluetooth_test_bluez.cc:86: for (const auto& connection :
gatt_connections_) {
A comment explaining why we need to close all connections and active sessions
would be nice.

[perja, 2017-01-23 09:05:34]

https://codereview.chromium.org/2640883002/diff/100001/device/bluetooth/test/...
File device/bluetooth/test/bluetooth_test_bluez.cc (right):

https://codereview.chromium.org/2640883002/diff/100001/device/bluetooth/test/...
device/bluetooth/test/bluetooth_test_bluez.cc:86: for (const auto& connection :
gatt_connections_) {
On 2017/01/22 20:51:55, ortuno wrote:
> A comment explaining why we need to close all connections and active sessions
> would be nice.

Done.