Chromad: Disable device attribute update after enrollment

Chromad: Disable device attribute update after enrollment

Attribute updates are not supported in Chromad, and disabling them
allows to get rid of the CloudPolicyClient right after enrollment has
finished.

BUG=677510
Review-Url: https://codereview.chromium.org/2640843002
Cr-Commit-Position: refs/heads/master@{#444444}
Committed: https://chromium.googlesource.com/chromium/src/+/e30959a32e573cc2264bafe4ab57fc93c6a234af

[Thiemo Nagel, 2017-01-18 14:02:15]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 14:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2017-01-18 14:03:06]

tnagel@chromium.org changed reviewers:
+ achuith@chromium.org

[Thiemo Nagel, 2017-01-18 14:03:06]

Hi Achuith,

may I kindly ask you to take a look?

Thank you,
Thiemo

[commit-bot: I haz the power, 2017-01-18 14:37:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 14:37:02]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2017-01-18 19:12:09]

Description was changed from

==========
Chromad: Disable device attribute update after enrollment

BUG=677510
==========

to

==========
Chromad: Disable device attribute update after enrollment

Attribute updates are not supported in Chromad, and disabling them
allows to get rid of the CloudPolicyClient right after enrollment has
finished.

BUG=677510
==========

[achuithb, 2017-01-18 19:19:24]

lgtm

https://codereview.chromium.org/2640843002/diff/1/chrome/browser/chromeos/log...
File
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
(right):

https://codereview.chromium.org/2640843002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc:178:
// TODO(pbond): remove this LOG once http://crbug.com/586961 is fixed.
Could you please remove this comment and log statement while you're here? The
bug appears to be fixed.

[Thiemo Nagel, 2017-01-18 19:47:56]

On 2017/01/18 19:19:24, achuithb wrote:
> lgtm
> 
>
https://codereview.chromium.org/2640843002/diff/1/chrome/browser/chromeos/log...
> File
> chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
> (right):
> 
>
https://codereview.chromium.org/2640843002/diff/1/chrome/browser/chromeos/log...
>
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc:178:
> // TODO(pbond): remove this LOG once http://crbug.com/586961 is fixed.
> Could you please remove this comment and log statement while you're here? The
> bug appears to be fixed.

After offline discussion with pbond: She prefers to keep them in for a couple of
months since she's not certain the bug has really been resolved.

[Thiemo Nagel, 2017-01-18 19:48:19]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 19:55:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484768899818380, "parent_rev":
"608e24db64fd84c9ebaff87bf07d50c3d34059d7", "commit_rev":
"e30959a32e573cc2264bafe4ab57fc93c6a234af"}

[commit-bot: I haz the power, 2017-01-18 19:55:48]

Description was changed from

==========
Chromad: Disable device attribute update after enrollment

Attribute updates are not supported in Chromad, and disabling them
allows to get rid of the CloudPolicyClient right after enrollment has
finished.

BUG=677510
==========

to

==========
Chromad: Disable device attribute update after enrollment

Attribute updates are not supported in Chromad, and disabling them
allows to get rid of the CloudPolicyClient right after enrollment has
finished.

BUG=677510

Review-Url: https://codereview.chromium.org/2640843002
Cr-Commit-Position: refs/heads/master@{#444444}
Committed:
https://chromium.googlesource.com/chromium/src/+/e30959a32e573cc2264bafe4ab57...
==========

[commit-bot: I haz the power, 2017-01-18 19:55:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e30959a32e573cc2264bafe4ab57...