Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 2640823002: [wasm] LinkError on imported i64 global (Closed)

Created:
3 years, 11 months ago by rossberg
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] LinkError on imported i64 global R=titzer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2640823002 Cr-Commit-Position: refs/heads/master@{#42460} Committed: https://chromium.googlesource.com/v8/v8/+/485fdde23cd6c76a8565adb46fed031bdb025f1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/wasm/wasm-module.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rossberg
3 years, 11 months ago (2017-01-18 13:46:14 UTC) #1
titzer
lgtm
3 years, 11 months ago (2017-01-18 13:49:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640823002/1
3 years, 11 months ago (2017-01-18 14:02:49 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 14:33:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/485fdde23cd6c76a8565adb46fed031bdb0...

Powered by Google App Engine
This is Rietveld 408576698