Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2640793008: Move VRDisplay timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VRDisplay timer to frame-specific TaskRunnerTimer. Move VRDisplay timer m_fullscreenCheckTimer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. BUG=624694 Review-Url: https://codereview.chromium.org/2640793008 Cr-Commit-Position: refs/heads/master@{#444998} Committed: https://chromium.googlesource.com/chromium/src/+/729562d9dd9a2e36b49039df31a94a09027e3674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-19 19:27:18 UTC) #4
haraken
Yeah, this looks like an internal task in Blink. UnspecedTimer makes sense. LGTM.
3 years, 11 months ago (2017-01-20 05:04:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640793008/1
3 years, 11 months ago (2017-01-20 06:14:37 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 06:20:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/729562d9dd9a2e36b49039df31a9...

Powered by Google App Engine
This is Rietveld 408576698