Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 2640793007: Eliminate redundant signatures. (Closed)

Created:
3 years, 11 months ago by Leaf
Modified:
3 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org, vsm
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eliminate redundant signatures. The check to see that a method signature was redundant was not handling generics correctly. This CL fixes it, so that we no longer emit redundant signatures for methods on generic classes. This should help with startup and code size a bit. Fixes https://github.com/dart-lang/sdk/issues/28432 BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/8ae2f82dce833e8e823b4b10f6505c421cecaa8e

Patch Set 1 #

Patch Set 2 : Eliminate redundant signatures #

Patch Set 3 : Restore comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -2169 lines) Patch
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 2 chunks +44 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 111 chunks +88 lines, -537 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 111 chunks +88 lines, -537 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 111 chunks +88 lines, -537 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 111 chunks +88 lines, -537 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 2 2 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Leaf
Note that this is dependent on this CL https://codereview.chromium.org/2642763006/ . I didn't bother to change ...
3 years, 11 months ago (2017-01-19 06:25:16 UTC) #2
Bob Nystrom
LGTM! Nice to see the SDK JS get smaller.
3 years, 11 months ago (2017-01-19 17:52:56 UTC) #4
Leaf
3 years, 11 months ago (2017-01-19 20:44:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8ae2f82dce833e8e823b4b10f6505c421cecaa8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698