src/full-codegen/full-codegen.h - Issue 2640793004: Revert remove dead hole check logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.h

Issue 2640793004: Revert remove dead hole check logic (Closed)

Patch Set: Revert "[crankshaft] Fix mips/mips64 build: remove unused variable" and "[crankshaft] Remove dead Variable hole-checking code" Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/full-codegen.h

diff --git a/src/full-codegen/full-codegen.h b/src/full-codegen/full-codegen.h

index 3635e29f6be09c0b35f20866a71048a59f014182..9a34cf93f0f2cf5f5e37b0808a052f8769527bdb 100644

--- a/src/full-codegen/full-codegen.h

+++ b/src/full-codegen/full-codegen.h

@@ -472,7 +472,8 @@ class FullCodeGenerator final : public AstVisitor<FullCodeGenerator> {

// Complete a variable assignment. The right-hand-side value is expected

// in the accumulator.

void EmitVariableAssignment(Variable* var, Token::Value op,

- FeedbackVectorSlot slot);

+ FeedbackVectorSlot slot,

+ HoleCheckMode hole_check_mode);

// Helper functions to EmitVariableAssignment

void EmitStoreToStackLocalOrContextSlot(Variable* var,

« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »