Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: src/full-codegen/full-codegen.h

Issue 2640793004: Revert remove dead hole check logic (Closed)
Patch Set: Revert "[crankshaft] Fix mips/mips64 build: remove unused variable" and "[crankshaft] Remove dead Variable hole-checking code" Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FULL_CODEGEN_FULL_CODEGEN_H_ 5 #ifndef V8_FULL_CODEGEN_FULL_CODEGEN_H_
6 #define V8_FULL_CODEGEN_FULL_CODEGEN_H_ 6 #define V8_FULL_CODEGEN_FULL_CODEGEN_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assert-scope.h" 9 #include "src/assert-scope.h"
10 #include "src/ast/ast.h" 10 #include "src/ast/ast.h"
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 Expression* right); 465 Expression* right);
466 466
467 // Assign to the given expression as if via '='. The right-hand-side value 467 // Assign to the given expression as if via '='. The right-hand-side value
468 // is expected in the accumulator. slot is only used if FLAG_vector_stores 468 // is expected in the accumulator. slot is only used if FLAG_vector_stores
469 // is true. 469 // is true.
470 void EmitAssignment(Expression* expr, FeedbackVectorSlot slot); 470 void EmitAssignment(Expression* expr, FeedbackVectorSlot slot);
471 471
472 // Complete a variable assignment. The right-hand-side value is expected 472 // Complete a variable assignment. The right-hand-side value is expected
473 // in the accumulator. 473 // in the accumulator.
474 void EmitVariableAssignment(Variable* var, Token::Value op, 474 void EmitVariableAssignment(Variable* var, Token::Value op,
475 FeedbackVectorSlot slot); 475 FeedbackVectorSlot slot,
476 HoleCheckMode hole_check_mode);
476 477
477 // Helper functions to EmitVariableAssignment 478 // Helper functions to EmitVariableAssignment
478 void EmitStoreToStackLocalOrContextSlot(Variable* var, 479 void EmitStoreToStackLocalOrContextSlot(Variable* var,
479 MemOperand location); 480 MemOperand location);
480 481
481 // Complete a named property assignment. The receiver is expected on top 482 // Complete a named property assignment. The receiver is expected on top
482 // of the stack and the right-hand-side value in the accumulator. 483 // of the stack and the right-hand-side value in the accumulator.
483 void EmitNamedPropertyAssignment(Assignment* expr); 484 void EmitNamedPropertyAssignment(Assignment* expr);
484 485
485 // Complete a keyed property assignment. The receiver and key are 486 // Complete a keyed property assignment. The receiver and key are
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
889 Address start_; 890 Address start_;
890 Address instruction_start_; 891 Address instruction_start_;
891 uint32_t length_; 892 uint32_t length_;
892 }; 893 };
893 894
894 895
895 } // namespace internal 896 } // namespace internal
896 } // namespace v8 897 } // namespace v8
897 898
898 #endif // V8_FULL_CODEGEN_FULL_CODEGEN_H_ 899 #endif // V8_FULL_CODEGEN_FULL_CODEGEN_H_
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698