Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2640783007: [heap] Marking cleanup (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Marking cleanup BUG= Review-Url: https://codereview.chromium.org/2640783007 Cr-Commit-Position: refs/heads/master@{#42906} Committed: https://chromium.googlesource.com/v8/v8/+/7c32e07d31974b98b5e4a3ea812ac429880b2d8c

Patch Set 1 : Replace SetMark #

Patch Set 2 : Replace MarkAllocationSite #

Patch Set 3 : Replace IsMarked #

Patch Set 4 : Compilation fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -55 lines) Patch
M src/heap/incremental-marking.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 15 chunks +21 lines, -31 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 2 3 1 chunk +1 line, -13 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (16 generated)
Michael Lippautz
ping
3 years, 10 months ago (2017-02-02 20:37:57 UTC) #14
Hannes Payer (out of office)
lgtm
3 years, 10 months ago (2017-02-03 03:57:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640783007/80001
3 years, 10 months ago (2017-02-03 05:30:15 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 06:01:23 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/7c32e07d31974b98b5e4a3ea812ac429880...

Powered by Google App Engine
This is Rietveld 408576698