Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2640783006: [turbofan] Assign proper types to various builtins. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign proper types to various builtins. Let the Typer assign proper types to Map, Set, WeakMap and WeakSet builtins. Also assign a proper type to Array.isArray, Object.assign and Object.create. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2640783006 Cr-Commit-Position: refs/heads/master@{#42535} Committed: https://chromium.googlesource.com/v8/v8/+/f23819ef6da470b26dae828b15f57291ffda3850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M src/compiler/typer.cc View 3 chunks +45 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-20 07:59:36 UTC) #1
Yang
On 2017/01/20 07:59:36, Benedikt Meurer wrote: lgtm.
3 years, 11 months ago (2017-01-20 08:23:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640783006/1
3 years, 11 months ago (2017-01-20 08:27:11 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 08:56:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f23819ef6da470b26dae828b15f57291ffd...

Powered by Google App Engine
This is Rietveld 408576698