Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: remoting/codec/BUILD.gn

Issue 2640783004: Cleanups in remoting gn files. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/codec/BUILD.gn
diff --git a/remoting/codec/BUILD.gn b/remoting/codec/BUILD.gn
index 2c8d343a899c310c18bb21d6891bd70c550b362c..85896de9f5e24e407c0788d88648be14b12318d5 100644
--- a/remoting/codec/BUILD.gn
+++ b/remoting/codec/BUILD.gn
@@ -2,13 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("codec") {
nicholss 2017/01/20 23:05:22 why delete this? A dep on :encoder :decoder was :
Sergey Ulanov 2017/01/20 23:41:41 It's to ensure that we don't have any targets that
- deps = [
- ":decoder",
- ":encoder",
- ]
-}
-
source_set("encoder") {
sources = [
"audio_encoder.h",
@@ -41,29 +34,6 @@ source_set("encoder") {
"//ui/gfx:color_space",
]
- if (is_nacl) {
- sources -= [
- "audio_encoder.h",
- "audio_encoder_opus.cc",
- "audio_encoder_opus.h",
- "video_encoder.cc",
- "video_encoder.h",
- "video_encoder_helper.cc",
- "video_encoder_helper.h",
- "video_encoder_verbatim.cc",
- "video_encoder_verbatim.h",
- "video_encoder_vpx.cc",
- "video_encoder_vpx.h",
- "webrtc_video_encoder_vpx.cc",
- "webrtc_video_encoder_vpx.h",
- ]
- deps -= [
- "//media",
- "//media:shared_memory_support",
- "//ui/gfx:color_space",
- ]
- }
-
# Opus depends on //media, which is not a supported include for iOS.
# Also disabled it on Android, to avoid dependency on //media.
# TODO(sergeyu): Cleanup host-only deps in client targets.
@@ -139,7 +109,8 @@ source_set("unit_tests") {
]
deps = [
- ":codec",
+ ":decoder",
+ ":encoder",
"//base",
"//remoting/proto",
"//testing/gtest",

Powered by Google App Engine
This is Rietveld 408576698