Cleanups in remoting gn files.

remoting/codec/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("codec") {

[nicholss, 2017/01/20 23:05:22]

why delete this? A dep on  :encoder :decoder was :codec (the file name) and then
you can just include the file path in gn without any targets.

[Sergey Ulanov, 2017/01/20 23:41:41]

It's to ensure that we don't have any targets that unintentionally depend on on
the encoder when they need only decoder.

-  deps = [
-    ":decoder",
-    ":encoder",
-  ]
-}
-
 source_set("encoder") {
   sources = [
     "audio_encoder.h",
     "audio_encoder_opus.cc",
     "audio_encoder_opus.h",
     "video_encoder.cc",
     "video_encoder.h",
     "video_encoder_helper.cc",
     "video_encoder_helper.h",
     "video_encoder_verbatim.cc",
@@ skipping 12 matching lines @@
     "//media",
     "//media:shared_memory_support",
     "//remoting/proto",
     "//third_party/libvpx",
     "//third_party/libyuv",
     "//third_party/opus",
     "//third_party/webrtc/modules/desktop_capture:primitives",
     "//ui/gfx:color_space",
   ]
 
-  if (is_nacl) {
-    sources -= [
-      "audio_encoder.h",
-      "audio_encoder_opus.cc",
-      "audio_encoder_opus.h",
-      "video_encoder.cc",
-      "video_encoder.h",
-      "video_encoder_helper.cc",
-      "video_encoder_helper.h",
-      "video_encoder_verbatim.cc",
-      "video_encoder_verbatim.h",
-      "video_encoder_vpx.cc",
-      "video_encoder_vpx.h",
-      "webrtc_video_encoder_vpx.cc",
-      "webrtc_video_encoder_vpx.h",
-    ]
-    deps -= [
-      "//media",
-      "//media:shared_memory_support",
-      "//ui/gfx:color_space",
-    ]
-  }
-
   # Opus depends on //media, which is not a supported include for iOS.
   # Also disabled it on Android, to avoid dependency on //media.
   # TODO(sergeyu): Cleanup host-only deps in client targets.
   if (is_ios || is_android) {
     sources -= [
       "audio_encoder_opus.cc",
       "audio_encoder_opus.h",
     ]
     deps -= [
       "//media",
@@ skipping 55 matching lines @@
     "audio_encoder_opus_unittest.cc",
     "codec_test.cc",
     "codec_test.h",
     "video_decoder_vpx_unittest.cc",
     "video_encoder_helper_unittest.cc",
     "video_encoder_verbatim_unittest.cc",
     "video_encoder_vpx_unittest.cc",
   ]
 
   deps = [
-    ":codec",
+    ":decoder",
+    ":encoder",
     "//base",
     "//remoting/proto",
     "//testing/gtest",
     "//third_party/webrtc/modules/desktop_capture",
     "//ui/gfx:color_space",
   ]
 
   if (is_ios || is_android) {
     sources -= [ "audio_encoder_opus_unittest.cc" ]
   }
 }