[Password Generation] Send id attribute to server for HTML based form classifier

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 #include <memory>
 #include <set>
 #include <vector>
@@ skipping 1348 matching lines @@
 }
 
 void WebFormControlElementToFormField(
     const WebFormControlElement& element,
     const FieldValueAndPropertiesMaskMap* field_value_and_properties_map,
     ExtractMask extract_mask,
     FormFieldData* field) {
   DCHECK(field);
   DCHECK(!element.isNull());
   CR_DEFINE_STATIC_LOCAL(WebString, kAutocomplete, ("autocomplete"));
+  CR_DEFINE_STATIC_LOCAL(WebString, kId, ("id"));
   CR_DEFINE_STATIC_LOCAL(WebString, kRole, ("role"));
   CR_DEFINE_STATIC_LOCAL(WebString, kPlaceholder, ("placeholder"));
   CR_DEFINE_STATIC_LOCAL(WebString, kClass, ("class"));
 
   // The label is not officially part of a WebFormControlElement; however, the
   // labels for all form control elements are scraped from the DOM and set in
   // WebFormElementToFormData.
   field->name = element.nameForAutofill();
+  base::string16 id = element.getAttribute(kId);
+  if (id != field->name)

[sebsg, 2017/01/18 19:22:49]

Can you also just make a quick note or refer to
HTMLFormControlElement::nameForAutofill like you did in server.proto?
I was a bit confused before I got to that comment :)

[kolos1, 2017/01/19 11:09:16]

Done.

Also removed the comment about the label. As I understand, the author of this CL
(https://codereview.chromium.org/1622004, see form_manager.cc) forgot to remove
it. 

+    field->id = id;
   field->form_control_type = element.formControlType().utf8();
   field->autocomplete_attribute = element.getAttribute(kAutocomplete).utf8();
   if (field->autocomplete_attribute.size() > kMaxDataLength) {
     // Discard overly long attribute values to avoid DOS-ing the browser
     // process.  However, send over a default string to indicate that the
     // attribute was present.
     field->autocomplete_attribute = "x-max-data-length-exceeded";
   }
   if (base::LowerCaseEqualsASCII(
           base::StringPiece16(element.getAttribute(kRole)), "presentation"))
@@ skipping 419 matching lines @@
     // Zero selection start is for password manager, which can show usernames
     // that do not begin with the user input value.
     selection_start = (offset == base::string16::npos) ? 0 : offset;
   }
 
   input_element->setSelectionRange(selection_start, suggestion.length());
 }
 
 }  // namespace form_util
 }  // namespace autofill