Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1622004: AutoFill: Parse HTMLLabel elements for form control element labels. (Closed)

Created:
10 years, 8 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, jam+cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

AutoFill: Parse HTMLLabel elements for form control element labels. BUG=40306 TEST=FormManagerTest.Labels Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43761

Patch Set 1 #

Total comments: 8

Patch Set 2 : Use vector, not map. Add invalid label test. #

Patch Set 3 : Add TODO comment. #

Patch Set 4 : Update constness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -55 lines) Patch
M chrome/renderer/form_manager.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/renderer/form_manager.cc View 1 2 3 10 chunks +78 lines, -39 lines 0 comments Download
M chrome/renderer/form_manager_unittest.cc View 1 2 chunks +48 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +18 lines, -4 lines 0 comments Download
M webkit/glue/form_field.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Hawkins
10 years, 8 months ago (2010-04-06 01:01:27 UTC) #1
dhollowa
http://codereview.chromium.org/1622004/diff/1/2 File chrome/renderer/form_manager.cc (right): http://codereview.chromium.org/1622004/diff/1/2#newcode136 chrome/renderer/form_manager.cc:136: name_map[field->name()] = field; field->name() is not guaranteed to be ...
10 years, 8 months ago (2010-04-06 02:11:50 UTC) #2
James Hawkins
http://codereview.chromium.org/1622004/diff/1/2 File chrome/renderer/form_manager.cc (right): http://codereview.chromium.org/1622004/diff/1/2#newcode136 chrome/renderer/form_manager.cc:136: name_map[field->name()] = field; On 2010/04/06 02:11:51, dhollowa wrote: > ...
10 years, 8 months ago (2010-04-06 03:39:09 UTC) #3
dhollowa
http://codereview.chromium.org/1622004/diff/1/2 File chrome/renderer/form_manager.cc (right): http://codereview.chromium.org/1622004/diff/1/2#newcode136 chrome/renderer/form_manager.cc:136: name_map[field->name()] = field; On 2010/04/06 03:39:09, James Hawkins wrote: ...
10 years, 8 months ago (2010-04-06 04:33:18 UTC) #4
James Hawkins
http://codereview.chromium.org/1622004/diff/1/2 File chrome/renderer/form_manager.cc (right): http://codereview.chromium.org/1622004/diff/1/2#newcode136 chrome/renderer/form_manager.cc:136: name_map[field->name()] = field; On 2010/04/06 04:33:18, dhollowa wrote: > ...
10 years, 8 months ago (2010-04-06 04:49:57 UTC) #5
dhollowa
LGTM.
10 years, 8 months ago (2010-04-06 16:11:25 UTC) #6
dhollowa
10 years, 8 months ago (2010-04-06 18:09:16 UTC) #7
SLGTM.

Powered by Google App Engine
This is Rietveld 408576698