Issue 2640773003: Don't focus the location bar for NTP navigations in non-selected tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2640773003: Don't focus the location bar for NTP navigations in non-selected tabs. (Closed)

Created:
3 years, 11 months ago by Charlie Reis

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Don't focus the location bar for NTP navigations in non-selected tabs. BUG=677716 TEST=See bug for repro steps. Review-Url: https://codereview.chromium.org/2624373002 Cr-Commit-Position: refs/heads/master@{#443338} (cherry picked from commit 8f3a9a68b2dcdd2c54cf49a41ad34729ab576702) Review-Url: https://codereview.chromium.org/2640773003 . Cr-Commit-Position: refs/branch-heads/2924@{#796} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/27ebece83822341efae80096834c649ce6822e64

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -4 lines)			Patch
	M	chrome/browser/ui/browser.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/browser_focus_uitest.cc	View		3 chunks	+36 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Charlie Reis

3 years, 11 months ago (2017-01-18 23:57:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
27ebece83822341efae80096834c649ce6822e64.