Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2640753002: CSS font-display: expose display property on FontFace (Closed)

Created:
3 years, 11 months ago by Kunihiko Sakamoto
Modified:
3 years, 11 months ago
Reviewers:
tkent
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS font-display: expose display property on FontFace This adds "display" attribute to FontFace interface that reflects the font-display value of corresponding @font-face CSS rule. Also, this adds "display" field to FontFaceDescriptors dictionary, to make it possible to construct a FontFace with specified font-display value. These are still protected behind the experimental features flag. This matches Firefox's experimental implementation. Spec discussion: https://github.com/tabatkins/specs/issues/54 BUG=682115 Review-Url: https://codereview.chromium.org/2640753002 Cr-Commit-Position: refs/heads/master@{#444617} Committed: https://chromium.googlesource.com/chromium/src/+/ec812adbe02d56c9efafcaa77c7dfd9121510959

Patch Set 1 #

Patch Set 2 : Fix webexposed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/css/fontface-properties.html View 7 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/fontface-properties-expected.txt View 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceDescriptors.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Kunihiko Sakamoto
Kent-san, could you take a look?
3 years, 11 months ago (2017-01-19 01:58:13 UTC) #12
tkent
lgtm
3 years, 11 months ago (2017-01-19 02:29:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640753002/20001
3 years, 11 months ago (2017-01-19 03:00:20 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 03:05:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ec812adbe02d56c9efafcaa77c7d...

Powered by Google App Engine
This is Rietveld 408576698