Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2640743004: [foozzie] Stop using asm validator until results are more stable (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Stop using asm validator until results are more stable The results are too noisy ATM. This switches off validate-asm for default comparisons. We can add back dedicated jobs later that switch it on. BUG=chromium:663714 NOTRY=true TBR=bradnelson@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2640743004 Cr-Commit-Position: refs/heads/master@{#42467} Committed: https://chromium.googlesource.com/v8/v8/+/dd789d87f9508d3cca11e86b71657641261e99b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/foozzie/v8_foozzie.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Please reopen any bugs that wrongly close automatically by this.
3 years, 11 months ago (2017-01-18 15:52:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640743004/1
3 years, 11 months ago (2017-01-18 15:52:46 UTC) #3
titzer
lgtm
3 years, 11 months ago (2017-01-18 15:52:46 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 15:54:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dd789d87f9508d3cca11e86b71657641261...

Powered by Google App Engine
This is Rietveld 408576698