Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2640743002: Revert of Apply image transformation for thumbnails loaded by loadDetachedImage. (Closed)

Created:
3 years, 11 months ago by yamaguchi
Modified:
3 years, 11 months ago
Reviewers:
oka
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Apply image transformation for thumbnails loaded by loadDetachedImage. (patchset #4 id:60001 of https://codereview.chromium.org/2630283002/ ) Reason for revert: crbug.com/682139 Original issue's description: > Apply image transformation for thumbnails loaded by loadDetachedImage. > > This change will fix 2 parts where we had wrong image orientation, > when there's EXIF image rotation/transfomration info. > 1. Tooltip thumbnail when an image is dragged in Files app. > 2. Low-density image tentatively shown in Gallery app. > > The drag thumbnail is changed to use the CANVAS mode, > because the IMAGE mode still doesn't work correctly. > > BUG=680420, 680414 > TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2630283002 > Cr-Commit-Position: refs/heads/master@{#443875} > Committed: https://chromium.googlesource.com/chromium/src/+/b1a8ea6390809eb8e166631a05eaf97406baf6ca TBR=oka@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=680420, 680414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -93 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 5 chunks +30 lines, -55 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yamaguchi
Created Revert of Apply image transformation for thumbnails loaded by loadDetachedImage.
3 years, 11 months ago (2017-01-18 07:50:13 UTC) #1
yamaguchi
3 years, 11 months ago (2017-01-18 12:42:43 UTC) #2
On 2017/01/18 07:50:13, yamaguchi wrote:
> Created Revert of Apply image transformation for thumbnails loaded by
> loadDetachedImage.

I will abandon this revert patch, because the original patch turned out not to
be the cause of the issue.

Powered by Google App Engine
This is Rietveld 408576698